Skip to content

Commit 89cac09

Browse files
committed
Mind important only for valid redirect tokens
Related feedback: - uBlockOrigin/uBlock-issues#1366 (comment)
1 parent 058f160 commit 89cac09

File tree

1 file changed

+6
-7
lines changed

1 file changed

+6
-7
lines changed

src/js/static-net-filtering.js

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4261,19 +4261,18 @@ FilterContainer.parseRedirectRequestValue = function(modifier) {
42614261
};
42624262

42634263
FilterContainer.compareRedirectRequests = function(a, b) {
4264-
const abits = a.bits, bbits = b.bits;
4264+
const { token: atok, priority: aint, bits: abits } =
4265+
FilterContainer.parseRedirectRequestValue(a.modifier);
4266+
if ( µb.redirectEngine.hasToken(atok) === false ) { return -1; }
4267+
const { token: btok, priority: bint, bits: bbits } =
4268+
FilterContainer.parseRedirectRequestValue(b.modifier);
4269+
if ( µb.redirectEngine.hasToken(btok) === false ) { return 1; }
42654270
if ( abits !== bbits ) {
42664271
if ( (abits & Important) !== 0 ) { return 1; }
42674272
if ( (bbits & Important) !== 0 ) { return -1; }
42684273
if ( (abits & AllowAction) !== 0 ) { return -1; }
42694274
if ( (bbits & AllowAction) !== 0 ) { return 1; }
42704275
}
4271-
const { token: atok, priority: aint } =
4272-
FilterContainer.parseRedirectRequestValue(a.modifier);
4273-
if ( µb.redirectEngine.hasToken(atok) === false ) { return -1; }
4274-
const { token: btok, priority: bint } =
4275-
FilterContainer.parseRedirectRequestValue(b.modifier);
4276-
if ( µb.redirectEngine.hasToken(btok) === false ) { return 1; }
42774276
return aint - bint;
42784277
};
42794278

0 commit comments

Comments
 (0)