Summary: Display thresholds values even when not in summaryTrendStats #4698
Conversation
internal/js/summary.js
Outdated
| console.log(info); | ||
| console.log(metric.values); | ||
|
|
There was a problem hiding this comment.
| console.log(info); | |
| console.log(metric.values); |
There was a problem hiding this comment.
Yeah, sorry, I forgot one extra force-push before opening the PR haha 😅
There was a problem hiding this comment.
Hehe no worries 😄 Been there, did that, many times 🫶
joanlopez
force-pushed
the
fix-4695
branch
3 times, most recently
from
616bd35 to
17d877e
Compare
| @@ -839,7 +839,7 @@ function renderThresholdResults( | |||
| : formatter.decorate(failMark, 'red'); | |||
|
|
|||
| const sourceText = formatter.decorate( | |||
| `'${threshold.source}'`, | |||
There was a problem hiding this comment.
This isn't directly related, but it's so small that I prefer to add it as part of this PR. It's not a huge deal, but I think it's nice if we trim the threshold's source before displaying it in the summary.
|
|
||
| var percentileThresholdSourceRe = regexp.MustCompile(`^p\((\d+(?:\.\d+)?)\)\s*([<>=])`) | ||
|
|
||
| func extractPercentileThresholdSource(source string) (agg string, percentile float64, isPercentile bool) { |
There was a problem hiding this comment.
I know this isn't ideal, but I cannot see any alternative to this that doesn't imply exposing more things from the metrics package and type (like the parsed expression and related code), and I think that isn't ideal as well because we do plan to do some refactors there soon-ish.
So, that's why I suggest to go with this, which should be fine as I don't expect the thresholds format to change anytime soon, especially now with v1.0 and the versioning strategy and guarantees.
What?
Makes it possible to display threshold values (since #4089) even when the aggregation on the thresholds expression (e.g.
p(99.5)) isn't included as part ofoptions.summaryTrendStats.Why?
Now those values aren't displayed (instead, it prints
undefined, which I would consider a bug), because we're not calculating values for aggregations other thanoptions.summaryTrendStats.Alternatively, we could just omit these lines from the summary, but I think these are valuable information for the user, and it's aligned with the goal of the revamped summary.
Checklist
make check) and all pass.Checklist: Documentation (only for k6 maintainers and if relevant)
Please do not merge this PR until the following items are filled out.
Related PR(s)/Issue(s)
Closes #4695