Add the ability to set server and enforcement parameters #1777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pete Wall <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR introduces configuration options for gRPC server parameters and keepalive enforcement in the OTLP receiver, exposing them via Helm values, JSON schema, templates, and documentation.
- Added
server_parametersandenforcement_policyin rendered outputs for tests and examples - Extended
values.yamlandvalues.schema.jsonto supportserverParametersandenforcementPolicy - Updated the OTLP Helm template and README to render and document the new settings
Reviewed Changes
Copilot reviewed 28 out of 28 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| charts/k8s-monitoring//tests//*/.rendered/output.yaml | Added server_parameters and enforcement_policy blocks to test outputs |
| charts/k8s-monitoring/docs/examples/**/{output.yaml,alloy-receiver.alloy} | Included new parameters in all example configurations |
| charts/k8s-monitoring/charts/feature-application-observability/values.yaml | Introduced serverParameters and enforcementPolicy fields |
| charts/k8s-monitoring/charts/feature-application-observability/values.schema.json | Extended schema to validate the new fields |
| charts/k8s-monitoring/charts/feature-application-observability/templates/_receiver_otlp.tpl | Template logic added to render the new parameters |
| charts/k8s-monitoring/charts/feature-application-observability/README.md | Documented defaults and descriptions for the new parameters |
dehaansa
approved these changes
Jul 17, 2025
Signed-off-by: Pete Wall <[email protected]>
Signed-off-by: Pete Wall <[email protected]>
|
Updated to fix the issues as well as use alloy's defaults. |
petewall
added a commit
that referenced
this pull request
Jul 17, 2025
* Add the ability to set server and enforcement parameters Signed-off-by: Pete Wall <[email protected]> * Fix and refactor to use Alloy's defaults Signed-off-by: Pete Wall <[email protected]> * update rendered output Signed-off-by: Pete Wall <[email protected]> --------- Signed-off-by: Pete Wall <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.