feat: enforce limits in distributors #16705
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grobinson-grafana
force-pushed
the
grobinson/enforce-limits-in-distributors
branch
from
428f318 to
187a246
Compare
github-actions
bot
added
the
type/docs
|
💻 Deploy preview deleted. |
grobinson-grafana
force-pushed
the
grobinson/enforce-limits-in-distributors
branch
from
187a246 to
78ae59e
Compare
| tenantConfigs *runtime.TenantConfigs | ||
| tenantsRetention *retention.TenantsRetention | ||
| ingestersRing ring.ReadRing | ||
| validator *Validator | ||
| pool *ring_client.Pool | ||
| ingesterClients *ring_client.Pool |
There was a problem hiding this comment.
I renamed this field as now we have a number of *ring_client.Pool.
| if factory == nil { | ||
| factory = ring_client.PoolAddrFunc(func(addr string) (ring_client.PoolClient, error) { | ||
| return client.New(clientCfg, addr) | ||
| ingesterClientFactory := cfg.factory |
There was a problem hiding this comment.
Same here.
periklis
reviewed
Mar 12, 2025
Comment on lines
-1179
to
+1310
| d.kafkaAppends.WithLabelValues(fmt.Sprintf("partition_%d", partitionID), "fail").Inc() | ||
| d.kafkaAppends.WithLabelValues(fmt.Sprintf("partition_%d", streamPartitionID), "fail").Inc() | ||
| finalErr = result.Err | ||
| } else { | ||
| d.kafkaAppends.WithLabelValues(fmt.Sprintf("partition_%d", partitionID), "success").Inc() | ||
| d.kafkaAppends.WithLabelValues(fmt.Sprintf("partition_%d", streamPartitionID), "success").Inc() |
There was a problem hiding this comment.
nit. Count the metadata appends in this or a separate metric, wdyt?
There was a problem hiding this comment.
I'm not sure if we know which record failed here, it's something I need to look into.
grobinson-grafana
force-pushed
the
grobinson/enforce-limits-in-distributors
branch
from
9f34f19 to
4a7d273
Compare
periklis
approved these changes
Mar 12, 2025
This was referenced Mar 20, 2025
This was referenced Mar 31, 2025
This was referenced Apr 14, 2025
This was referenced Apr 23, 2025
This was referenced May 5, 2025
This was referenced May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This pull request enforces stream limits in distributors.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR