address review comments

Author: marcsanmi

examples/grafana-agent-auto-instrumentation/ebpf-otel/README.md

@@ -1,4 +1,4 @@
-# OpenTelemetry eBPF profiler example
+# OpenTelemetry eBPF profiler examples
 
 **⚠️ Important: Linux-only Support**
 This example can only be run on Linux systems (amd64/arm64) as it relies on eBPF technology which is specific to the Linux kernel. The profiler requires privileged access to system resources.
@@ -14,6 +14,8 @@ These examples demonstrate:
 
 Follow the build instructions:
 
+1. Build the profiler binary:
+
 ```bash
 # Clone the repository
 git clone https://github.com/open-telemetry/opentelemetry-ebpf-profiler
@@ -25,13 +27,18 @@ make docker-image
 # Build the profiler binary
 make agent
 ```
+
+2. Copy the built binary to the example directory:
+```bash
+# Copy the ebpf-profiler binary to the example directory
+cp ebpf-profiler /path/to/example/directory/
+```
 **Note:** The following examples will consider that an `ebpf-profiler` binary is already existing on each example root directory.
 
-For more details, please refer to opentelemetry-ebpf-profiler [docs](https://github.com/open-telemetry/opentelemetry-ebpf-profiler?tab=readme-ov-file#building)
+For more details, please refer to opentelemetry-ebpf-profiler [repository](https://github.com/open-telemetry/opentelemetry-ebpf-profiler)
 
 ## Docker example
-
-After building the profiler binary, start the environment:
+1. Start the environment:
 
 ```bash
 # Start all services
@@ -40,10 +47,15 @@ docker-compose up --build
 # To clean up
 docker-compose down
 ```
+2. Access the UI:
+```bash
+# Access Grafana
+http://localhost:3000
+```
 
 ## Kubernetes example
 
-1. After building the profiler binary, build and prepare the profiler image:
+1. Build and prepare the profiler image:
 
 ```bash
 # Build the image with the binary
@@ -64,4 +76,7 @@ kubectl delete -f kubernetes/
 ```bash
 # Port forward Grafana
 kubectl port-forward svc/grafana-service 3000:3000
+
+# Access Grafana
+http://localhost:3000
 ```

examples/grafana-agent-auto-instrumentation/ebpf-otel/docker/docker-compose.yml

@@ -4,7 +4,7 @@ services:
     image: otel/opentelemetry-collector-contrib:latest
     command: ["--config=/etc/otel-collector-config.yaml", "--feature-gates=service.profilesSupport"]
     volumes:
-      - ./otel-collector-config.yaml:/etc/otel-collector-config.yaml
+      - ./config/otel-collector-config.yaml:/etc/otel-collector-config.yaml
     ports:
       - "4317:4317"
       - "4318:4318"
@@ -29,6 +29,7 @@ services:
 
   pyroscope:
     image: grafana/pyroscope:latest
+    command: ["-self-profiling.disable-push=true"]
     ports:
       - "4040:4040"
     networks:

examples/grafana-agent-auto-instrumentation/ebpf-otel/kubernetes/otel-collector.yaml

@@ -11,24 +11,6 @@ spec:
       labels:
         app: otel-collector
     spec:
-#      initContainers:
-#      - name: wait-for-pyroscope
-#        image: busybox
-#        command: [ 'sh', '-c', '
-#          timeout=10;
-#          counter=0;
-#          while [ $counter -lt $timeout ]; do
-#            if nc -z pyroscope-service 4040; then
-#              echo "Pyroscope is up!";
-#              exit 0;
-#            fi;
-#            echo "Waiting for pyroscope... ($counter/$timeout)";
-#            counter=$((counter+1));
-#            sleep 1;
-#          done;
-#          echo "Timeout waiting for pyroscope";
-#          exit 1
-#        ' ]
       containers:
         - name: otel-collector
           image: otel/opentelemetry-collector-contrib:latest

examples/grafana-agent-auto-instrumentation/ebpf-otel/kubernetes/pyroscope.yaml

@@ -15,6 +15,8 @@ spec:
       containers:
         - name: pyroscope
           image: grafana/pyroscope:latest
+          args:
+            - "-self-profiling.disable-push=true"
           ports:
             - containerPort: 4040
 ---