feat(v2): move default storage paths under ./data/v2/ (#4978)

* feat(v2): move default storage paths under ./data/v2/

Ensures all persistent V2 storage (metastore raft WAL, snapshots, and
FSM BoltDB) defaults to paths under ./data/v2/, so Docker users mounting
-v storage:/data have all state inside the volume.

* fix(helm): pin metastore data dirs to old paths to avoid breaking upgrades

The binary defaults for metastore.data-dir, metastore.raft.dir, and
metastore.raft.snapshots-dir changed from ./data-metastore/* to
./data/v2/metastore/*. Explicitly set the old paths in the Helm chart
so existing deployments don't lose their data on upgrade.

Author: simonswine

operations/pyroscope/helm/pyroscope/rendered/micro-services-v2.yaml

@@ -3384,6 +3384,9 @@ spec:
             - "-metastore.snapshot-compact-on-restore=true"
             - "-query-backend.address=dns:///_grpc._tcp.pyroscope-dev-query-backend-headless.$(NAMESPACE_FQDN):9095"
             - "-metastore.address=kubernetes:///pyroscope-dev-metastore-headless.$(NAMESPACE_FQDN):9095"
+            - "-metastore.data-dir=./data-metastore/data"
+            - "-metastore.raft.dir=./data-metastore/raft"
+            - "-metastore.raft.snapshots-dir=./data-metastore/raft"
             - "-metastore.raft.bind-address=:9099"
             - "-metastore.raft.server-id=$(POD_NAME).$(PYROSCOPE_METASTORE_SERVICE)"
             - "-metastore.raft.advertise-address=$(POD_NAME).$(PYROSCOPE_METASTORE_SERVICE)"

operations/pyroscope/helm/pyroscope/rendered/single-binary-v2.yaml

@@ -1428,6 +1428,9 @@ spec:
             - "-storage.backend=filesystem"
             - "-query-backend.address=dns:///_grpc._tcp.pyroscope-dev-headless.$(NAMESPACE_FQDN):9095"
             - "-metastore.address=kubernetes:///pyroscope-dev-headless.$(NAMESPACE_FQDN):9095"
+            - "-metastore.data-dir=./data-metastore/data"
+            - "-metastore.raft.dir=./data-metastore/raft"
+            - "-metastore.raft.snapshots-dir=./data-metastore/raft"
             - "-metastore.raft.bind-address=:9099"
             - "-metastore.raft.server-id=$(POD_NAME).$(PYROSCOPE_METASTORE_SERVICE)"
             - "-metastore.raft.advertise-address=$(POD_NAME).$(PYROSCOPE_METASTORE_SERVICE)"

operations/pyroscope/helm/pyroscope/templates/deployments-statefulsets.yaml

@@ -102,6 +102,15 @@ spec:
           {{- end }}
           {{- /* metastore specific v2 migration config */}}
           {{-  if $isMetastore }}
+          {{-  if (not (hasKey $extraArgs "metastore.data-dir"))  }}
+            - "-metastore.data-dir=./data-metastore/data"
+          {{- end }}
+          {{-  if (not (hasKey $extraArgs "metastore.raft.dir"))  }}
+            - "-metastore.raft.dir=./data-metastore/raft"
+          {{- end }}
+          {{-  if (not (hasKey $extraArgs "metastore.raft.snapshots-dir"))  }}
+            - "-metastore.raft.snapshots-dir=./data-metastore/raft"
+          {{- end }}
           {{-  if (not (hasKey $extraArgs "metastore.raft.server-id"))  }}
             - "-metastore.raft.bind-address=:{{ .Values.pyroscope.metastore.port }}"
           {{- end }}

pkg/metastore/fsm/fsm.go

@@ -60,7 +60,7 @@ func (cfg *Config) RegisterFlagsWithPrefix(prefix string, f *flag.FlagSet) {
 	f.StringVar(&cfg.SnapshotCompression, prefix+"snapshot-compression", "zstd", "Compression algorithm to use for snapshots. Supported compressions: zstd.")
 	f.IntVar(&cfg.SnapshotRateLimit, prefix+"snapshot-rate-limit", 15, "Rate limit for snapshot writer in MB/s.")
 	f.BoolVar(&cfg.SnapshotCompactOnRestore, prefix+"snapshot-compact-on-restore", false, "Compact the database on restore.")
-	f.StringVar(&cfg.DataDir, prefix+"data-dir", "./data-metastore/data", "Directory to store the data.")
+	f.StringVar(&cfg.DataDir, prefix+"data-dir", "./data/v2/metastore/data", "Directory to store the data.")
 }
 
 // FSM implements the raft.FSM interface.

pkg/metastore/raftnode/node.go

@@ -62,7 +62,7 @@ type Config struct {
 }
 
 const (
-	defaultRaftDir      = "./data-metastore/raft"
+	defaultRaftDir      = "./data/v2/metastore/raft"
 	defaultSnapshotsDir = defaultRaftDir
 
 	defaultWALCacheEntries       = 512