Skip to content

Clean up enum and constant naming conventions #1008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ckbedwell opened this issue Nov 28, 2024 · 0 comments
Open

Clean up enum and constant naming conventions #1008

ckbedwell opened this issue Nov 28, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request techdebt Work to improve the DX of the application.

Comments

@ckbedwell
Copy link
Contributor

Problem

Throughout the Synthetic Monitoring app code enums and constants have inconsistent naming conventions.

Completion criteria

Convert all enums and constants throughout the code base to have a consistent naming convention.

Reference comment by @w1kman

// Bad 
enum AM_I_A_CONST_OR_A_ENUM {
  FOO,
  BAR,
}

// Bad 🤨
enum AM_I_A_CONST_OR_A_ENUM {
  Foo,
  Bar,
}

// Bad 🤨
enum AlmostAnEnum {
  FOO,
  BAR,
}

// Good 💖
enum ClearlyAnEnum {
  Foo,
  Bar,
}
@ckbedwell ckbedwell added enhancement New feature or request techdebt Work to improve the DX of the application. labels Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request techdebt Work to improve the DX of the application.
Projects
None yet
Development

No branches or pull requests

2 participants