Skip to content

Provide better UX and error handling for bulk actions that can't be executed #1012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ckbedwell opened this issue Dec 9, 2024 · 1 comment
Labels
bug Something isn't working frontend Needs to be implemented in the frontend application

Comments

@ckbedwell
Copy link
Contributor

ckbedwell commented Dec 9, 2024

Problem

When selecting multiple checks to bulk remove probes, if one of the checks only has a single probe (so removing it would result in it having zero probes which is invalid), the request errors and is unable to complete with no useful feedback except the update failed.

Acceptance criteria

Please explore options to handle this for the best UX:

  1. Present a more useful error message indicating the problematic check allowing the user to take action to correct it
  2. Carry out the request where possible but exclude the problematic check and highlight the probes weren't removed from this check.

Please ensure the implemented solution has adequate integration tests.

@ckbedwell ckbedwell added bug Something isn't working frontend Needs to be implemented in the frontend application labels Dec 9, 2024
@ckbedwell ckbedwell changed the title Prove better UX and error handling for bulk actions that can't be executed Provide better UX and error handling for bulk actions that can't be executed Dec 9, 2024
@peterschretlen
Copy link
Contributor

This may be a change required in the API, as the response does not indicate what action can't be performed.
TBD what the expected behaviour is.

Could:

  • Perform the actions that can be performed.
  • Indicate the subset of actions that failed.

Alternative is we continue with the all-or-nothing behaviour, but provide better messaging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend Needs to be implemented in the frontend application
Projects
None yet
Development

No branches or pull requests

2 participants