Skip to content

Commit 77c3e8a

Browse files
authored
CI fixes (#266)
1 parent 7177a07 commit 77c3e8a

File tree

3 files changed

+8
-4
lines changed

3 files changed

+8
-4
lines changed

.github/workflows/test.yml

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,9 +58,14 @@ jobs:
5858
- name: Build solution [Debug]
5959
working-directory: src
6060
run: dotnet build --no-restore -c Debug
61-
- name: Test solution [Debug]
61+
- name: Test solution [Debug] with code coverage
62+
if: ${{ startsWith(matrix.os, 'ubuntu') }}
63+
working-directory: src
64+
run: dotnet test --no-restore --no-build -p:CollectCoverage=true -p:DoesNotReturnAttribute="DoesNotReturnAttribute"
65+
- name: Test solution [Debug] without code coverage
66+
if: ${{ startsWith(matrix.os, 'windows') }}
6267
working-directory: src
63-
run: dotnet test --no-restore -p:CollectCoverage=true -p:DoesNotReturnAttribute="DoesNotReturnAttribute"
68+
run: dotnet test --no-restore --no-build
6469
- name: Upload coverage to codecov
6570
if: ${{ startsWith(matrix.os, 'ubuntu') }}
6671
uses: codecov/codecov-action@v3

src/Directory.Build.props

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
<PropertyGroup>
44
<VersionPrefix>8.0.0-preview</VersionPrefix>
55
<LangVersion>latest</LangVersion>
6-
<GenerateAssemblyInfo>true</GenerateAssemblyInfo>
76
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
87
<WarningsNotAsErrors>CS8766</WarningsNotAsErrors>
98
<GenerateDocumentationFile>true</GenerateDocumentationFile>

src/GraphQLParser/GraphQLParser.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
<PackageReference Include="System.Threading.Tasks.Extensions" Version="4.5.4" Condition="'$(TargetFramework)' == 'netstandard2.0'" />
1616
</ItemGroup>
1717

18-
<ItemGroup>
18+
<ItemGroup Condition="'$(IsTestProject)' != 'true'">
1919
<InternalsVisibleTo Condition="'$(SignAssembly)' == 'true'" Include="$(MSBuildProjectName).Tests, $(_FriendAssembliesPublicKey);$(MSBuildProjectName).Benchmarks, $(_FriendAssembliesPublicKey)"/>
2020
<InternalsVisibleTo Condition="'$(SignAssembly)' != 'true'" Include="$(MSBuildProjectName).Tests;$(MSBuildProjectName).Benchmarks"/>
2121
</ItemGroup>

0 commit comments

Comments
 (0)