From be1b159dd96eac0e5c2b394d22ef7d9f7dfa3d18 Mon Sep 17 00:00:00 2001 From: Shane Krueger Date: Wed, 19 Oct 2022 23:51:33 -0400 Subject: [PATCH 1/3] Verify StringBuilder and MemoryStream writing is synchronous --- .../Visitors/SDLPrinterTests.cs | 21 +++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/src/GraphQLParser.Tests/Visitors/SDLPrinterTests.cs b/src/GraphQLParser.Tests/Visitors/SDLPrinterTests.cs index 9cc8d086..272de62e 100644 --- a/src/GraphQLParser.Tests/Visitors/SDLPrinterTests.cs +++ b/src/GraphQLParser.Tests/Visitors/SDLPrinterTests.cs @@ -1,3 +1,4 @@ +using System.Text; using GraphQLParser.Visitors; namespace GraphQLParser.Tests.Visitors; @@ -750,6 +751,26 @@ public async Task Directive_Without_Parent_Should_Be_Printed() writer.ToString().ShouldBe("@upper"); } + [Fact] + public void StringBuilder_Runs_Synchronously() + { + var query = "kitchenSink".ReadGraphQLFile().Parse(); + var sb = new StringBuilder(); + using var writer = new StringWriter(sb); + var printer = new SDLPrinter(); + printer.PrintAsync(query, writer).IsCompletedSuccessfully.ShouldBeTrue(); + } + + [Fact] + public void UTF8_MemoryStream_Runs_Synchronously() + { + var query = "kitchenSink".ReadGraphQLFile().Parse(); + using var ms = new MemoryStream(); + using var writer = new StreamWriter(ms); + var printer = new SDLPrinter(); + printer.PrintAsync(query, writer).IsCompletedSuccessfully.ShouldBeTrue(); + } + [Theory] [InlineData("query a { name }")] [InlineData("directive @skip(if: Boolean!) on FIELD | FRAGMENT_SPREAD | INLINE_FRAGMENT")] From 020ed5872e7579b1fee7b846b66b38d52c6c8de4 Mon Sep 17 00:00:00 2001 From: Shane Krueger Date: Thu, 20 Oct 2022 00:00:28 -0400 Subject: [PATCH 2/3] Update --- src/GraphQLParser.Tests/Visitors/SDLPrinterTests.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/GraphQLParser.Tests/Visitors/SDLPrinterTests.cs b/src/GraphQLParser.Tests/Visitors/SDLPrinterTests.cs index 272de62e..61ebd3f4 100644 --- a/src/GraphQLParser.Tests/Visitors/SDLPrinterTests.cs +++ b/src/GraphQLParser.Tests/Visitors/SDLPrinterTests.cs @@ -754,7 +754,7 @@ public async Task Directive_Without_Parent_Should_Be_Printed() [Fact] public void StringBuilder_Runs_Synchronously() { - var query = "kitchenSink".ReadGraphQLFile().Parse(); + var query = "KitchenSink".ReadGraphQLFile().Parse(); var sb = new StringBuilder(); using var writer = new StringWriter(sb); var printer = new SDLPrinter(); @@ -764,7 +764,7 @@ public void StringBuilder_Runs_Synchronously() [Fact] public void UTF8_MemoryStream_Runs_Synchronously() { - var query = "kitchenSink".ReadGraphQLFile().Parse(); + var query = "KitchenSink".ReadGraphQLFile().Parse(); using var ms = new MemoryStream(); using var writer = new StreamWriter(ms); var printer = new SDLPrinter(); From 2034f328c76ad8bb3ce4316ea5866d5fc4144cce Mon Sep 17 00:00:00 2001 From: Shane Krueger Date: Thu, 3 Nov 2022 12:07:32 -0400 Subject: [PATCH 3/3] Update src/GraphQLParser.Tests/Visitors/SDLPrinterTests.cs Co-authored-by: Ivan Maximov --- src/GraphQLParser.Tests/Visitors/SDLPrinterTests.cs | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/GraphQLParser.Tests/Visitors/SDLPrinterTests.cs b/src/GraphQLParser.Tests/Visitors/SDLPrinterTests.cs index 61ebd3f4..e9fc9f94 100644 --- a/src/GraphQLParser.Tests/Visitors/SDLPrinterTests.cs +++ b/src/GraphQLParser.Tests/Visitors/SDLPrinterTests.cs @@ -754,21 +754,21 @@ public async Task Directive_Without_Parent_Should_Be_Printed() [Fact] public void StringBuilder_Runs_Synchronously() { - var query = "KitchenSink".ReadGraphQLFile().Parse(); + var document = "KitchenSink".ReadGraphQLFile().Parse(); var sb = new StringBuilder(); using var writer = new StringWriter(sb); var printer = new SDLPrinter(); - printer.PrintAsync(query, writer).IsCompletedSuccessfully.ShouldBeTrue(); + printer.PrintAsync(document, writer).IsCompletedSuccessfully.ShouldBeTrue(); } [Fact] public void UTF8_MemoryStream_Runs_Synchronously() { - var query = "KitchenSink".ReadGraphQLFile().Parse(); + var document = "KitchenSink".ReadGraphQLFile().Parse(); using var ms = new MemoryStream(); using var writer = new StreamWriter(ms); var printer = new SDLPrinter(); - printer.PrintAsync(query, writer).IsCompletedSuccessfully.ShouldBeTrue(); + printer.PrintAsync(document, writer).IsCompletedSuccessfully.ShouldBeTrue(); } [Theory]