Skip to content

fix: typescript commonjs module resolution with node16,nodenext #1466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions .changeset/tasty-lizards-fix.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
---
'@envelop/core': patch
'@envelop/apollo-datasources': patch
'@envelop/apollo-federation': patch
'@envelop/apollo-server-errors': patch
'@envelop/apollo-tracing': patch
'@envelop/auth0': patch
'@envelop/dataloader': patch
'@envelop/depth-limit': patch
'@envelop/disable-introspection': patch
'@envelop/execute-subscription-event': patch
'@envelop/extended-validation': patch
'@envelop/filter-operation-type': patch
'@envelop/fragment-arguments': patch
'@envelop/generic-auth': patch
'@envelop/graphql-jit': patch
'@envelop/graphql-middleware': patch
'@envelop/graphql-modules': patch
'@envelop/live-query': patch
'@envelop/newrelic': patch
'@envelop/opentelemetry': patch
'@envelop/operation-field-permissions': patch
'@envelop/parser-cache': patch
'@envelop/persisted-operations': patch
'@envelop/preload-assets': patch
'@envelop/prometheus': patch
'@envelop/rate-limiter': patch
'@envelop/resource-limitations': patch
'@envelop/response-cache': patch
'@envelop/response-cache-redis': patch
'@envelop/sentry': patch
'@envelop/statsd': patch
'@envelop/validation-cache': patch
'@envelop/testing': patch
'@envelop/types': patch
---

Fix CommonJS TypeScript resolution with `moduleResolution` `node16` or `nodenext`
1 change: 0 additions & 1 deletion bob.config.js

This file was deleted.

38 changes: 19 additions & 19 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,24 +3,24 @@
"author": "Dotan Simha <[email protected]>",
"license": "MIT",
"workspaces": [
"./website",
"./packages/*",
"./packages/plugins/*",
"./examples/apollo-server",
"./examples/graphql-ws",
"./examples/graphql-sse",
"./examples/graphql-socket.io",
"./examples/simple-http",
"./examples/graphql-helix",
"./examples/graphql-helix-auth0",
"./examples/lambda-aws",
"./examples/azure-functions",
"./examples/google-cloud-functions",
"./examples/cloudflare-workers",
"./examples/with-esm",
"./examples/typegraphql",
"./examples/nexus",
"./examples/express-graphql"
"website",
"packages/*",
"packages/plugins/*",
"examples/apollo-server",
"examples/graphql-ws",
"examples/graphql-sse",
"examples/graphql-socket.io",
"examples/simple-http",
"examples/graphql-helix",
"examples/graphql-helix-auth0",
"examples/lambda-aws",
"examples/azure-functions",
"examples/google-cloud-functions",
"examples/cloudflare-workers",
"examples/with-esm",
"examples/typegraphql",
"examples/nexus",
"examples/express-graphql"
],
"scripts": {
"prepare": "husky install",
Expand Down Expand Up @@ -56,7 +56,7 @@
"@typescript-eslint/parser": "5.27.0",
"apollo-server": "3.5.0",
"benchmark": "2.1.4",
"bob-the-bundler": "2.0.0",
"bob-the-bundler": "4.0.0",
"chalk": "5.0.1",
"eslint": "8.17.0",
"eslint-config-prettier": "8.5.0",
Expand Down
4 changes: 2 additions & 2 deletions packages/core/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"exports": {
".": {
"require": {
"types": "./dist/typings/index.d.ts",
"types": "./dist/typings/index.d.cts",
"default": "./dist/cjs/index.js"
},
"import": {
Expand All @@ -37,7 +37,7 @@
},
"./*": {
"require": {
"types": "./dist/typings/*.d.ts",
"types": "./dist/typings/*.d.cts",
"default": "./dist/cjs/*.js"
},
"import": {
Expand Down
4 changes: 2 additions & 2 deletions packages/plugins/apollo-datasources/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"exports": {
".": {
"require": {
"types": "./dist/typings/index.d.ts",
"types": "./dist/typings/index.d.cts",
"default": "./dist/cjs/index.js"
},
"import": {
Expand All @@ -28,7 +28,7 @@
},
"./*": {
"require": {
"types": "./dist/typings/*.d.ts",
"types": "./dist/typings/*.d.cts",
"default": "./dist/cjs/*.js"
},
"import": {
Expand Down
4 changes: 2 additions & 2 deletions packages/plugins/apollo-federation/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"exports": {
".": {
"require": {
"types": "./dist/typings/index.d.ts",
"types": "./dist/typings/index.d.cts",
"default": "./dist/cjs/index.js"
},
"import": {
Expand All @@ -28,7 +28,7 @@
},
"./*": {
"require": {
"types": "./dist/typings/*.d.ts",
"types": "./dist/typings/*.d.cts",
"default": "./dist/cjs/*.js"
},
"import": {
Expand Down
4 changes: 2 additions & 2 deletions packages/plugins/apollo-server-errors/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"exports": {
".": {
"require": {
"types": "./dist/typings/index.d.ts",
"types": "./dist/typings/index.d.cts",
"default": "./dist/cjs/index.js"
},
"import": {
Expand All @@ -28,7 +28,7 @@
},
"./*": {
"require": {
"types": "./dist/typings/*.d.ts",
"types": "./dist/typings/*.d.cts",
"default": "./dist/cjs/*.js"
},
"import": {
Expand Down
4 changes: 2 additions & 2 deletions packages/plugins/apollo-tracing/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"exports": {
".": {
"require": {
"types": "./dist/typings/index.d.ts",
"types": "./dist/typings/index.d.cts",
"default": "./dist/cjs/index.js"
},
"import": {
Expand All @@ -28,7 +28,7 @@
},
"./*": {
"require": {
"types": "./dist/typings/*.d.ts",
"types": "./dist/typings/*.d.cts",
"default": "./dist/cjs/*.js"
},
"import": {
Expand Down
4 changes: 2 additions & 2 deletions packages/plugins/auth0/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"exports": {
".": {
"require": {
"types": "./dist/typings/index.d.ts",
"types": "./dist/typings/index.d.cts",
"default": "./dist/cjs/index.js"
},
"import": {
Expand All @@ -28,7 +28,7 @@
},
"./*": {
"require": {
"types": "./dist/typings/*.d.ts",
"types": "./dist/typings/*.d.cts",
"default": "./dist/cjs/*.js"
},
"import": {
Expand Down
4 changes: 2 additions & 2 deletions packages/plugins/dataloader/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"exports": {
".": {
"require": {
"types": "./dist/typings/index.d.ts",
"types": "./dist/typings/index.d.cts",
"default": "./dist/cjs/index.js"
},
"import": {
Expand All @@ -28,7 +28,7 @@
},
"./*": {
"require": {
"types": "./dist/typings/*.d.ts",
"types": "./dist/typings/*.d.cts",
"default": "./dist/cjs/*.js"
},
"import": {
Expand Down
4 changes: 2 additions & 2 deletions packages/plugins/depth-limit/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"exports": {
".": {
"require": {
"types": "./dist/typings/index.d.ts",
"types": "./dist/typings/index.d.cts",
"default": "./dist/cjs/index.js"
},
"import": {
Expand All @@ -28,7 +28,7 @@
},
"./*": {
"require": {
"types": "./dist/typings/*.d.ts",
"types": "./dist/typings/*.d.cts",
"default": "./dist/cjs/*.js"
},
"import": {
Expand Down
4 changes: 2 additions & 2 deletions packages/plugins/disable-introspection/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"exports": {
".": {
"require": {
"types": "./dist/typings/index.d.ts",
"types": "./dist/typings/index.d.cts",
"default": "./dist/cjs/index.js"
},
"import": {
Expand All @@ -28,7 +28,7 @@
},
"./*": {
"require": {
"types": "./dist/typings/*.d.ts",
"types": "./dist/typings/*.d.cts",
"default": "./dist/cjs/*.js"
},
"import": {
Expand Down
4 changes: 2 additions & 2 deletions packages/plugins/execute-subscription-event/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"exports": {
".": {
"require": {
"types": "./dist/typings/index.d.ts",
"types": "./dist/typings/index.d.cts",
"default": "./dist/cjs/index.js"
},
"import": {
Expand All @@ -28,7 +28,7 @@
},
"./*": {
"require": {
"types": "./dist/typings/*.d.ts",
"types": "./dist/typings/*.d.cts",
"default": "./dist/cjs/*.js"
},
"import": {
Expand Down
4 changes: 2 additions & 2 deletions packages/plugins/extended-validation/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"exports": {
".": {
"require": {
"types": "./dist/typings/index.d.ts",
"types": "./dist/typings/index.d.cts",
"default": "./dist/cjs/index.js"
},
"import": {
Expand All @@ -28,7 +28,7 @@
},
"./*": {
"require": {
"types": "./dist/typings/*.d.ts",
"types": "./dist/typings/*.d.cts",
"default": "./dist/cjs/*.js"
},
"import": {
Expand Down
4 changes: 2 additions & 2 deletions packages/plugins/filter-operation-type/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"exports": {
".": {
"require": {
"types": "./dist/typings/index.d.ts",
"types": "./dist/typings/index.d.cts",
"default": "./dist/cjs/index.js"
},
"import": {
Expand All @@ -28,7 +28,7 @@
},
"./*": {
"require": {
"types": "./dist/typings/*.d.ts",
"types": "./dist/typings/*.d.cts",
"default": "./dist/cjs/*.js"
},
"import": {
Expand Down
4 changes: 2 additions & 2 deletions packages/plugins/fragment-arguments/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"exports": {
".": {
"require": {
"types": "./dist/typings/index.d.ts",
"types": "./dist/typings/index.d.cts",
"default": "./dist/cjs/index.js"
},
"import": {
Expand All @@ -27,7 +27,7 @@
},
"./*": {
"require": {
"types": "./dist/typings/*.d.ts",
"types": "./dist/typings/*.d.cts",
"default": "./dist/cjs/*.js"
},
"import": {
Expand Down
4 changes: 2 additions & 2 deletions packages/plugins/generic-auth/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"exports": {
".": {
"require": {
"types": "./dist/typings/index.d.ts",
"types": "./dist/typings/index.d.cts",
"default": "./dist/cjs/index.js"
},
"import": {
Expand All @@ -28,7 +28,7 @@
},
"./*": {
"require": {
"types": "./dist/typings/*.d.ts",
"types": "./dist/typings/*.d.cts",
"default": "./dist/cjs/*.js"
},
"import": {
Expand Down
4 changes: 2 additions & 2 deletions packages/plugins/graphql-jit/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"exports": {
".": {
"require": {
"types": "./dist/typings/index.d.ts",
"types": "./dist/typings/index.d.cts",
"default": "./dist/cjs/index.js"
},
"import": {
Expand All @@ -28,7 +28,7 @@
},
"./*": {
"require": {
"types": "./dist/typings/*.d.ts",
"types": "./dist/typings/*.d.cts",
"default": "./dist/cjs/*.js"
},
"import": {
Expand Down
4 changes: 2 additions & 2 deletions packages/plugins/graphql-middleware/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"exports": {
".": {
"require": {
"types": "./dist/typings/index.d.ts",
"types": "./dist/typings/index.d.cts",
"default": "./dist/cjs/index.js"
},
"import": {
Expand All @@ -28,7 +28,7 @@
},
"./*": {
"require": {
"types": "./dist/typings/*.d.ts",
"types": "./dist/typings/*.d.cts",
"default": "./dist/cjs/*.js"
},
"import": {
Expand Down
4 changes: 2 additions & 2 deletions packages/plugins/graphql-modules/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"exports": {
".": {
"require": {
"types": "./dist/typings/index.d.ts",
"types": "./dist/typings/index.d.cts",
"default": "./dist/cjs/index.js"
},
"import": {
Expand All @@ -28,7 +28,7 @@
},
"./*": {
"require": {
"types": "./dist/typings/*.d.ts",
"types": "./dist/typings/*.d.cts",
"default": "./dist/cjs/*.js"
},
"import": {
Expand Down
Loading