Skip to content

Can we change the name of ObjectMapperConfigurer? #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bsara opened this issue Feb 25, 2020 · 2 comments
Closed

Can we change the name of ObjectMapperConfigurer? #234

bsara opened this issue Feb 25, 2020 · 2 comments
Labels
enhancement
Milestone
9.1.0

Comments

@bsara
Copy link
Contributor

bsara commented Feb 25, 2020 •
edited
Loading

With the reorganization of code in the graph-java-... projects. There are now two ObjectMapperConfigurer classes. One in this project and one in graphql-java-tools. It seems like it would be prudent to rename them each to be specific to their respective projects...that, or share the code somehow between them. I just got bit by the fact that I thought I was using the correct ObjectMapperConfigurer because I thought that there was only one...only to finally discover, after a few hours of debugging, that there are actually two classes with the same name.

Perhaps we could name them GraphQLServletObjectMapperConfigurer and GraphQLSchemaParserObjectMapperConfigurer?
@oliemansm
Copy link
Member

Yeah, that would indeed be better, good point.

@oliemansm oliemansm modified the milestones: 9.0.2, 9.1.0 Mar 31, 2020
@oliemansm
Copy link
Member

Included in 9.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
9.1.0
Development

No branches or pull requests
2 participants
@bsara @oliemansm