Skip to content

Add logger for GraphQL execution exception #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
czchen opened this issue May 25, 2016 · 1 comment
Closed

Add logger for GraphQL execution exception #7

czchen opened this issue May 25, 2016 · 1 comment

Comments

@czchen
Copy link

czchen commented May 25, 2016

The current implementation catch all GraphQL execution exception and return as errors in response. However, the detail information of exception like line number, file name, call stack are missing. It would be difficult to debug when not having these information.

I think it could be better to have a new member logger, and when there is an execution exception, it can use logger.exception to log this exception for debugging.

@syrusakbary
Copy link
Member

This issue was fixed in graphql-python/graphql-core#41 (commits graphql-python/graphql-core@f2175f5, graphql-python/graphql-core@0143e08).

Closing issue :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants