Skip to content

Commit f089930

Browse files
committed
update tests
1 parent d4bf019 commit f089930

File tree

2 files changed

+11
-23
lines changed

2 files changed

+11
-23
lines changed

graphene_sqlalchemy/tests/test_query.py

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import graphene
2-
from graphene.relay import Connection, Node
2+
from graphene.relay import Node
33

44
from ..converter import convert_sqlalchemy_composite
55
from ..fields import SQLAlchemyConnectionField
@@ -96,14 +96,10 @@ class Meta:
9696
model = Article
9797
interfaces = (Node,)
9898

99-
class ArticleConnection(Connection):
100-
class Meta:
101-
node = ArticleNode
102-
10399
class Query(graphene.ObjectType):
104100
node = Node.Field()
105101
reporter = graphene.Field(ReporterNode)
106-
all_articles = SQLAlchemyConnectionField(ArticleConnection)
102+
all_articles = SQLAlchemyConnectionField(ArticleNode.connection)
107103

108104
def resolve_reporter(self, _info):
109105
return session.query(Reporter).first()
@@ -230,13 +226,9 @@ class Meta:
230226
model = Editor
231227
interfaces = (Node,)
232228

233-
class EditorConnection(Connection):
234-
class Meta:
235-
node = EditorNode
236-
237229
class Query(graphene.ObjectType):
238230
node = Node.Field()
239-
all_editors = SQLAlchemyConnectionField(EditorConnection)
231+
all_editors = SQLAlchemyConnectionField(EditorNode.connection)
240232

241233
query = """
242234
query {

graphene_sqlalchemy/tests/test_sort_enums.py

Lines changed: 8 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
import sqlalchemy as sa
33

44
from graphene import Argument, Enum, List, ObjectType, Schema
5-
from graphene.relay import Connection, Node
5+
from graphene.relay import Node
66

77
from ..fields import SQLAlchemyConnectionField
88
from ..types import SQLAlchemyObjectType
@@ -249,22 +249,18 @@ class Meta:
249249
model = Pet
250250
interfaces = (Node,)
251251

252-
class PetConnection(Connection):
253-
class Meta:
254-
node = PetNode
255-
256252
class Query(ObjectType):
257-
defaultSort = SQLAlchemyConnectionField(PetConnection)
258-
nameSort = SQLAlchemyConnectionField(PetConnection)
259-
multipleSort = SQLAlchemyConnectionField(PetConnection)
260-
descSort = SQLAlchemyConnectionField(PetConnection)
253+
defaultSort = SQLAlchemyConnectionField(PetNode.connection)
254+
nameSort = SQLAlchemyConnectionField(PetNode.connection)
255+
multipleSort = SQLAlchemyConnectionField(PetNode.connection)
256+
descSort = SQLAlchemyConnectionField(PetNode.connection)
261257
singleColumnSort = SQLAlchemyConnectionField(
262-
PetConnection, sort=Argument(PetNode.sort_enum())
258+
PetNode.connection, sort=Argument(PetNode.sort_enum())
263259
)
264260
noDefaultSort = SQLAlchemyConnectionField(
265-
PetConnection, sort=PetNode.sort_argument(has_default=False)
261+
PetNode.connection, sort=PetNode.sort_argument(has_default=False)
266262
)
267-
noSort = SQLAlchemyConnectionField(PetConnection, sort=None)
263+
noSort = SQLAlchemyConnectionField(PetNode.connection, sort=None)
268264

269265
query = """
270266
query sortTest {

0 commit comments

Comments
 (0)