Skip to content

Commit fd04cc3

Browse files
committed
chore: run pre commit on PR (hook update due to incompatible hooks with local machine)
1 parent 18a7c54 commit fd04cc3

10 files changed

+227
-197
lines changed

.pre-commit-config.yaml

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
default_language_version:
2-
python: python3.7
2+
python: python3.8
33
repos:
44
- repo: https://github.com/pre-commit/pre-commit-hooks
55
rev: v4.2.0
@@ -12,7 +12,7 @@ repos:
1212
- id: trailing-whitespace
1313
exclude: README.md
1414
- repo: https://github.com/pycqa/isort
15-
rev: 5.10.1
15+
rev: 5.12.0
1616
hooks:
1717
- id: isort
1818
name: isort (python)

graphene_sqlalchemy/converter.py

+55-55
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
import typing
44
import uuid
55
from decimal import Decimal
6-
from typing import Any, Optional, Union, cast, Dict, TypeVar
6+
from typing import Any, Dict, Optional, TypeVar, Union, cast
77

88
from sqlalchemy import types as sqa_types
99
from sqlalchemy.dialects import postgresql
@@ -101,12 +101,12 @@ def is_column_nullable(column):
101101

102102

103103
def convert_sqlalchemy_relationship(
104-
relationship_prop,
105-
obj_type,
106-
connection_field_factory,
107-
batching,
108-
orm_field_name,
109-
**field_kwargs,
104+
relationship_prop,
105+
obj_type,
106+
connection_field_factory,
107+
batching,
108+
orm_field_name,
109+
**field_kwargs,
110110
):
111111
"""
112112
:param sqlalchemy.RelationshipProperty relationship_prop:
@@ -147,7 +147,7 @@ def dynamic_type():
147147

148148

149149
def _convert_o2o_or_m2o_relationship(
150-
relationship_prop, obj_type, batching, orm_field_name, **field_kwargs
150+
relationship_prop, obj_type, batching, orm_field_name, **field_kwargs
151151
):
152152
"""
153153
Convert one-to-one or many-to-one relationshsip. Return an object field.
@@ -175,7 +175,7 @@ def _convert_o2o_or_m2o_relationship(
175175

176176

177177
def _convert_o2m_or_m2m_relationship(
178-
relationship_prop, obj_type, batching, connection_field_factory, **field_kwargs
178+
relationship_prop, obj_type, batching, connection_field_factory, **field_kwargs
179179
):
180180
"""
181181
Convert one-to-many or many-to-many relationshsip. Return a list field or a connection field.
@@ -281,11 +281,11 @@ def convert_sqlalchemy_column(column_prop, registry, resolver, **field_kwargs):
281281

282282
@singledispatchbymatchfunction
283283
def convert_sqlalchemy_type( # noqa
284-
type_arg: Any,
285-
column: Optional[Union[MapperProperty, hybrid_property]] = None,
286-
registry: Registry = None,
287-
replace_type_vars: typing.Dict[str, Any] = None,
288-
**kwargs,
284+
type_arg: Any,
285+
column: Optional[Union[MapperProperty, hybrid_property]] = None,
286+
registry: Registry = None,
287+
replace_type_vars: typing.Dict[str, Any] = None,
288+
**kwargs,
289289
):
290290
if replace_type_vars and type_arg in replace_type_vars:
291291
return replace_type_vars[type_arg]
@@ -301,7 +301,7 @@ def convert_sqlalchemy_type( # noqa
301301

302302
@convert_sqlalchemy_type.register(safe_isinstance(DeclarativeMeta))
303303
def convert_sqlalchemy_model_using_registry(
304-
type_arg: Any, registry: Registry = None, **kwargs
304+
type_arg: Any, registry: Registry = None, **kwargs
305305
):
306306
registry_ = registry or get_global_registry()
307307

@@ -353,35 +353,35 @@ def convert_column_to_string(type_arg: Any, **kwargs):
353353
@convert_sqlalchemy_type.register(column_type_eq(sqa_utils.UUIDType))
354354
@convert_sqlalchemy_type.register(column_type_eq(uuid.UUID))
355355
def convert_column_to_uuid(
356-
type_arg: Any,
357-
**kwargs,
356+
type_arg: Any,
357+
**kwargs,
358358
):
359359
return graphene.UUID
360360

361361

362362
@convert_sqlalchemy_type.register(column_type_eq(sqa_types.DateTime))
363363
@convert_sqlalchemy_type.register(column_type_eq(datetime.datetime))
364364
def convert_column_to_datetime(
365-
type_arg: Any,
366-
**kwargs,
365+
type_arg: Any,
366+
**kwargs,
367367
):
368368
return graphene.DateTime
369369

370370

371371
@convert_sqlalchemy_type.register(column_type_eq(sqa_types.Time))
372372
@convert_sqlalchemy_type.register(column_type_eq(datetime.time))
373373
def convert_column_to_time(
374-
type_arg: Any,
375-
**kwargs,
374+
type_arg: Any,
375+
**kwargs,
376376
):
377377
return graphene.Time
378378

379379

380380
@convert_sqlalchemy_type.register(column_type_eq(sqa_types.Date))
381381
@convert_sqlalchemy_type.register(column_type_eq(datetime.date))
382382
def convert_column_to_date(
383-
type_arg: Any,
384-
**kwargs,
383+
type_arg: Any,
384+
**kwargs,
385385
):
386386
return graphene.Date
387387

@@ -390,10 +390,10 @@ def convert_column_to_date(
390390
@convert_sqlalchemy_type.register(column_type_eq(sqa_types.Integer))
391391
@convert_sqlalchemy_type.register(column_type_eq(int))
392392
def convert_column_to_int_or_id(
393-
type_arg: Any,
394-
column: Optional[Union[MapperProperty, hybrid_property]] = None,
395-
registry: Registry = None,
396-
**kwargs,
393+
type_arg: Any,
394+
column: Optional[Union[MapperProperty, hybrid_property]] = None,
395+
registry: Registry = None,
396+
**kwargs,
397397
):
398398
# fixme drop the primary key processing from here in another pr
399399
if column is not None:
@@ -405,8 +405,8 @@ def convert_column_to_int_or_id(
405405
@convert_sqlalchemy_type.register(column_type_eq(sqa_types.Boolean))
406406
@convert_sqlalchemy_type.register(column_type_eq(bool))
407407
def convert_column_to_boolean(
408-
type_arg: Any,
409-
**kwargs,
408+
type_arg: Any,
409+
**kwargs,
410410
):
411411
return graphene.Boolean
412412

@@ -416,19 +416,19 @@ def convert_column_to_boolean(
416416
@convert_sqlalchemy_type.register(column_type_eq(sqa_types.Numeric))
417417
@convert_sqlalchemy_type.register(column_type_eq(sqa_types.BigInteger))
418418
def convert_column_to_float(
419-
type_arg: Any,
420-
**kwargs,
419+
type_arg: Any,
420+
**kwargs,
421421
):
422422
return graphene.Float
423423

424424

425425
@convert_sqlalchemy_type.register(column_type_eq(postgresql.ENUM))
426426
@convert_sqlalchemy_type.register(column_type_eq(sqa_types.Enum))
427427
def convert_enum_to_enum(
428-
type_arg: Any,
429-
column: Optional[Union[MapperProperty, hybrid_property]] = None,
430-
registry: Registry = None,
431-
**kwargs,
428+
type_arg: Any,
429+
column: Optional[Union[MapperProperty, hybrid_property]] = None,
430+
registry: Registry = None,
431+
**kwargs,
432432
):
433433
if column is None or isinstance(column, hybrid_property):
434434
raise Exception("SQL-Enum conversion requires a column")
@@ -439,9 +439,9 @@ def convert_enum_to_enum(
439439
# TODO Make ChoiceType conversion consistent with other enums
440440
@convert_sqlalchemy_type.register(column_type_eq(sqa_utils.ChoiceType))
441441
def convert_choice_to_enum(
442-
type_arg: sqa_utils.ChoiceType,
443-
column: Optional[Union[MapperProperty, hybrid_property]] = None,
444-
**kwargs,
442+
type_arg: sqa_utils.ChoiceType,
443+
column: Optional[Union[MapperProperty, hybrid_property]] = None,
444+
**kwargs,
445445
):
446446
if column is None or isinstance(column, hybrid_property):
447447
raise Exception("ChoiceType conversion requires a column")
@@ -457,8 +457,8 @@ def convert_choice_to_enum(
457457

458458
@convert_sqlalchemy_type.register(column_type_eq(sqa_utils.ScalarListType))
459459
def convert_scalar_list_to_list(
460-
type_arg: Any,
461-
**kwargs,
460+
type_arg: Any,
461+
**kwargs,
462462
):
463463
return graphene.List(graphene.String)
464464

@@ -474,10 +474,10 @@ def init_array_list_recursive(inner_type, n):
474474
@convert_sqlalchemy_type.register(column_type_eq(sqa_types.ARRAY))
475475
@convert_sqlalchemy_type.register(column_type_eq(postgresql.ARRAY))
476476
def convert_array_to_list(
477-
type_arg: Any,
478-
column: Optional[Union[MapperProperty, hybrid_property]] = None,
479-
registry: Registry = None,
480-
**kwargs,
477+
type_arg: Any,
478+
column: Optional[Union[MapperProperty, hybrid_property]] = None,
479+
registry: Registry = None,
480+
**kwargs,
481481
):
482482
if column is None or isinstance(column, hybrid_property):
483483
raise Exception("SQL-Array conversion requires a column")
@@ -496,27 +496,27 @@ def convert_array_to_list(
496496
@convert_sqlalchemy_type.register(column_type_eq(postgresql.JSON))
497497
@convert_sqlalchemy_type.register(column_type_eq(postgresql.JSONB))
498498
def convert_json_to_string(
499-
type_arg: Any,
500-
**kwargs,
499+
type_arg: Any,
500+
**kwargs,
501501
):
502502
return JSONString
503503

504504

505505
@convert_sqlalchemy_type.register(column_type_eq(sqa_utils.JSONType))
506506
@convert_sqlalchemy_type.register(column_type_eq(sqa_types.JSON))
507507
def convert_json_type_to_string(
508-
type_arg: Any,
509-
**kwargs,
508+
type_arg: Any,
509+
**kwargs,
510510
):
511511
return JSONString
512512

513513

514514
@convert_sqlalchemy_type.register(column_type_eq(sqa_types.Variant))
515515
def convert_variant_to_impl_type(
516-
type_arg: sqa_types.Variant,
517-
column: Optional[Union[MapperProperty, hybrid_property]] = None,
518-
registry: Registry = None,
519-
**kwargs,
516+
type_arg: sqa_types.Variant,
517+
column: Optional[Union[MapperProperty, hybrid_property]] = None,
518+
registry: Registry = None,
519+
**kwargs,
520520
):
521521
if column is None or isinstance(column, hybrid_property):
522522
raise Exception("Vaiant conversion requires a column")
@@ -547,7 +547,7 @@ def is_union(type_arg: Any, **kwargs) -> bool:
547547

548548

549549
def graphene_union_for_py_union(
550-
obj_types: typing.List[graphene.ObjectType], registry
550+
obj_types: typing.List[graphene.ObjectType], registry
551551
) -> graphene.Union:
552552
union_type = registry.get_union_for_object_types(obj_types)
553553

@@ -590,8 +590,8 @@ def convert_sqlalchemy_hybrid_property_union(type_arg: Any, **kwargs):
590590

591591
# Now check if every type is instance of an ObjectType
592592
if not all(
593-
isinstance(graphene_type, type(graphene.ObjectType))
594-
for graphene_type in graphene_types
593+
isinstance(graphene_type, type(graphene.ObjectType))
594+
for graphene_type in graphene_types
595595
):
596596
raise ValueError(
597597
"Cannot convert hybrid_property Union to graphene.Union: the Union contains scalars. "

graphene_sqlalchemy/filters.py

+6
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
"BaseTypeFilterSelf", Dict[str, Any], InputObjectTypeContainer
1717
)
1818

19+
1920
class SQLAlchemyFilterInputField(graphene.InputField):
2021
def __init__(
2122
self,
@@ -42,6 +43,7 @@ def __init__(
4243

4344
self.model_attr = model_attr
4445

46+
4547
def _get_functions_by_regex(
4648
regex: str, subtract_regex: str, class_: Type
4749
) -> List[Tuple[str, Dict[str, Any]]]:
@@ -305,11 +307,13 @@ def execute_filters(
305307

306308
return query, clauses
307309

310+
308311
class SQLEnumFilter(FieldFilter):
309312
"""Basic Filter for Scalars in Graphene.
310313
We want this filter to use Dynamic fields so it provides the base
311314
filtering methods ("eq, nEq") for different types of scalars.
312315
The Dynamic fields will resolve to Meta.filtered_type"""
316+
313317
class Meta:
314318
graphene_type = graphene.Enum
315319

@@ -326,11 +330,13 @@ def n_eq_filter(
326330
) -> Union[Tuple[Query, Any], Any]:
327331
return not_(field == val.value)
328332

333+
329334
class PyEnumFilter(FieldFilter):
330335
"""Basic Filter for Scalars in Graphene.
331336
We want this filter to use Dynamic fields so it provides the base
332337
filtering methods ("eq, nEq") for different types of scalars.
333338
The Dynamic fields will resolve to Meta.filtered_type"""
339+
334340
class Meta:
335341
graphene_type = graphene.Enum
336342

0 commit comments

Comments
 (0)