Skip to content

Commit e5ec5da

Browse files
committed
Updated resolver to use (root, info, **args)
1 parent e25a92d commit e5ec5da

36 files changed

+50
-4085
lines changed

graphql/error/tests/test_base.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,15 +44,15 @@ def resolver(context, *_):
4444
('test_reraise', 'result.errors[0].reraise()'),
4545
('reraise', 'six.reraise(type(self), self, self.stack)'),
4646
# ('reraise', 'raise value.with_traceback(tb)'),
47-
('resolve_or_error', 'return executor.execute(resolve_fn, source, args, context, info)'),
47+
('resolve_or_error', 'return executor.execute(resolve_fn, source, info, **args)'),
4848
('execute', 'return fn(*args, **kwargs)'), ('resolver', "raise Exception('Failed')")
4949
]
5050
# assert formatted_tb == [
5151
# ('test_reraise', 'result.errors[0].reraise()'),
5252
# ('reraise', 'six.reraise(type(self), self, self.stack)'),
5353
# ('on_complete_resolver', 'result = __resolver(*args, **kwargs)'),
5454
# # ('reraise', 'raise value.with_traceback(tb)'),
55-
# # ('resolve_or_error', 'return executor.execute(resolve_fn, source, args, context, info)'),
55+
# # ('resolve_or_error', 'return executor.execute(resolve_fn, source, info, **args)'),
5656
# # ('execute', 'return fn(*args, **kwargs)'),
5757
# ('resolver', "raise Exception('Failed')")
5858
# ]

graphql/execution/base.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -288,7 +288,7 @@ def __init__(self, field_name, field_asts, return_type, parent_type,
288288
self.context = context
289289

290290

291-
def default_resolve_fn(source, args, context, info):
291+
def default_resolve_fn(source, info, **args):
292292
"""If a resolve function is not given, then a default resolve behavior is used which takes the property of the source object
293293
of the same name as the field and returns it as the result, or if it's a function, returns the result of calling that function."""
294294
name = info.field_name

graphql/execution/executor.py

Lines changed: 3 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -17,25 +17,14 @@
1717
collect_fields, default_resolve_fn, get_field_def,
1818
get_operation_root_type)
1919
from .executors.sync import SyncExecutor
20-
from .experimental.executor import execute as experimental_execute
2120
from .middleware import MiddlewareManager
2221

2322
logger = logging.getLogger(__name__)
2423

2524

26-
use_experimental_executor = False
27-
28-
2925
def execute(schema, document_ast, root_value=None, context_value=None,
3026
variable_values=None, operation_name=None, executor=None,
3127
return_promise=False, middleware=None):
32-
if use_experimental_executor:
33-
return experimental_execute(
34-
schema, document_ast, root_value, context_value,
35-
variable_values, operation_name, executor,
36-
return_promise, middleware
37-
)
38-
3928
assert schema, 'Must provide schema'
4029
assert isinstance(schema, GraphQLSchema), (
4130
'Schema must be an instance of GraphQLSchema. Also ensure that there are ' +
@@ -186,7 +175,7 @@ def resolve_field(exe_context, parent_type, source, field_asts):
186175
)
187176

188177
executor = exe_context.executor
189-
result = resolve_or_error(resolve_fn_middleware, source, args, context, info, executor)
178+
result = resolve_or_error(resolve_fn_middleware, source, info, args, executor)
190179

191180
return complete_value_catching_error(
192181
exe_context,
@@ -197,9 +186,9 @@ def resolve_field(exe_context, parent_type, source, field_asts):
197186
)
198187

199188

200-
def resolve_or_error(resolve_fn, source, args, context, info, executor):
189+
def resolve_or_error(resolve_fn, source, info, args, executor):
201190
try:
202-
return executor.execute(resolve_fn, source, args, context, info)
191+
return executor.execute(resolve_fn, source, info, **args)
203192
except Exception as e:
204193
logger.exception("An error occurred while resolving field {}.{}".format(
205194
info.parent_type.name, info.field_name

graphql/execution/experimental/__init__.py

Whitespace-only changes.

graphql/execution/experimental/executor.py

Lines changed: 0 additions & 66 deletions
This file was deleted.

graphql/execution/experimental/fragment.py

Lines changed: 0 additions & 254 deletions
This file was deleted.

0 commit comments

Comments
 (0)