Skip to content

graphql-core-3.2.0 cannot import name 'format_error' #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
eMerzh opened this issue Jan 17, 2022 · 3 comments
Closed

graphql-core-3.2.0 cannot import name 'format_error' #156

eMerzh opened this issue Jan 17, 2022 · 3 comments

Comments

@eMerzh
Copy link

eMerzh commented Jan 17, 2022

I'm just trying to do the upgrade, but i got:

File "graphql/controllers.py", line 13, in <module>
from graphql_server import GraphQLParams, GraphQLResponse, HttpQueryError, encode_execution_results, get_graphql_params
File ".venv/lib/python3.10/site-packages/graphql_server/__init__.py", line 15, in <module>
from graphql.error import format_error as format_error_default
ImportError: cannot import name 'format_error' from 'graphql.error' (.venv/lib/python3.10/site-packages/graphql/error/__init__.py)

By the way, here is two notes:

  1. Many many thanks for the maintenance of this project 👏
  2. not sure ho hard it would be, but it will really help the upgrade to have a comprenhive changelog of what's new, what's possible breaking, and what are the ,new features.... because we might not follow gql.js so closely to be able to tell exactly what's what...
@Cito
Copy link
Member

Cito commented Jan 17, 2022

Thanks - there is a already a ticket for this here in graphql-server.

Generally, packages using GraphQL-core 3 should always pin the minor version, since it corresponds to the major version of GraphQL.js which can have breaking changes - see also #137.

Any yes, will try to provide more comprehensive changelogs.

@Cito Cito closed this as completed Jan 17, 2022
@eMerzh
Copy link
Author

eMerzh commented Jan 17, 2022

oups sorry...

thanks for your quick reply

@Cito
Copy link
Member

Cito commented Jan 17, 2022

This is now solved in graphql-server 3.0.0b5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants