Skip to content

Does 'to_dict' will be implemented in graphql-core-next? #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yanghg-basefx opened this issue Nov 20, 2018 · 2 comments
Closed

Does 'to_dict' will be implemented in graphql-core-next? #17

yanghg-basefx opened this issue Nov 20, 2018 · 2 comments
Assignees
Labels
question Further information is requested

Comments

@yanghg-basefx
Copy link

I raise an issue before Out of memory when wrong use graphql with dataloader, but now I find this repo and to_dict is not exist in ExecutionResult. Does it will be implemented? If not, please close that issue, and I will remove it in my project.

But GraphQL-Server is using this function, please note.

Thanks so much!

@Cito
Copy link
Member

Cito commented Nov 21, 2018

This just returns a dictionary with error and data as keys (instead of the named tuple), and it formats the errors. I don't find this really useful, and it does two things at once which has always a certain smell.

I'd like to get input from @syrusakbary - can this be changed in GraphQL-Server to make it compatible? Or should I really add this to graphql-core-next?

@Cito Cito added the question Further information is requested label Nov 21, 2018
@Cito
Copy link
Member

Cito commented May 2, 2019

There will be a new version of GraphQL-server-core based on GraphQL-core-next (graphql-python/graphql-server#20), which will probably not need this, or maybe we will add it then if necessary/reasonable.

@Cito Cito closed this as completed May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants