Skip to content

Commit c9ca66b

Browse files
authored
Merge branch 'graphql-python:master' into master
2 parents a6314f5 + b8705c2 commit c9ca66b

File tree

4 files changed

+23
-18
lines changed

4 files changed

+23
-18
lines changed

graphql_server/__init__.py

+4
Original file line numberDiff line numberDiff line change
@@ -255,6 +255,10 @@ def get_response(
255255
if not params.query:
256256
raise HttpQueryError(400, "Must provide query string.")
257257

258+
# Sanity check query
259+
if not isinstance(params.query, str):
260+
raise HttpQueryError(400, "Unexpected query type.")
261+
258262
schema_validation_errors = validate_schema(schema)
259263
if schema_validation_errors:
260264
return ExecutionResult(data=None, errors=schema_validation_errors)

setup.py

+12-16
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,7 @@
11
from re import search
22
from setuptools import setup, find_packages
33

4-
install_requires = [
5-
"graphql-core>=3.1.0,<4",
6-
"typing-extensions>=3.7.4,<4"
7-
]
4+
install_requires = ["graphql-core>=3.1.0,<4", "typing-extensions>=3.7.4,<4"]
85

96
tests_requires = [
107
"pytest>=5.4,<5.5",
@@ -23,11 +20,11 @@
2320
] + tests_requires
2421

2522
install_flask_requires = [
26-
"flask>=0.7.0",
23+
"flask>=0.7.0<1",
2724
]
2825

2926
install_sanic_requires = [
30-
"sanic>=20.3.0",
27+
"sanic>=20.3.0,<21",
3128
]
3229

3330
install_webob_requires = [
@@ -38,17 +35,16 @@
3835
"aiohttp>=3.5.0,<4",
3936
]
4037

41-
install_quart_requires = [
42-
"quart>=0.6.15"
43-
]
38+
install_quart_requires = ["quart>=0.6.15,<1"]
4439

45-
install_all_requires = \
46-
install_requires + \
47-
install_flask_requires + \
48-
install_sanic_requires + \
49-
install_webob_requires + \
50-
install_aiohttp_requires + \
51-
install_quart_requires
40+
install_all_requires = (
41+
install_requires
42+
+ install_flask_requires
43+
+ install_sanic_requires
44+
+ install_webob_requires
45+
+ install_aiohttp_requires
46+
+ install_quart_requires
47+
)
5248

5349
with open("graphql_server/version.py") as version_file:
5450
version = search('version = "(.*)"', version_file.read()).group(1)

tests/sanic/app.py

+3
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,9 @@
88
from .schema import Schema
99

1010

11+
Sanic.test_mode = True
12+
13+
1114
def create_app(path="/graphql", **kwargs):
1215
app = Sanic(__name__)
1316
app.debug = True

tests/test_query.py

+4-2
Original file line numberDiff line numberDiff line change
@@ -495,8 +495,10 @@ def test_handles_errors_caused_by_a_lack_of_query():
495495

496496

497497
def test_handles_errors_caused_by_invalid_query_type():
498-
results, params = run_http_query(schema, "get", dict(query=42))
499-
assert results == [(None, [{"message": "Must provide Source. Received: 42."}])]
498+
with raises(HttpQueryError) as exc_info:
499+
results, params = run_http_query(schema, "get", dict(query=42))
500+
501+
assert exc_info.value == HttpQueryError(400, "Unexpected query type.")
500502

501503

502504
def test_handles_batch_correctly_if_is_disabled():

0 commit comments

Comments
 (0)