Skip to content

Expand test suite for resolve data #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JeffRMoore opened this issue Apr 9, 2016 · 0 comments
Open

Expand test suite for resolve data #351

JeffRMoore opened this issue Apr 9, 2016 · 0 comments

Comments

@JeffRMoore
Copy link
Contributor

Currently there is only one test case for "gets execution info in resolver" which does not test the breadth of execution info. It would be useful to expand the test cases around what information the resolve functions can expect to receive. Currently, only rootValue is tested from the GraphQLResolveInfo parameter. The suite should have the same kind of test for the other fields, especially fieldASTs, returnType, and parentType in nested and nonNull conditions. It should also test all three functions that receive GraphQLResolveInfo.

This can help make it easier to change the execute and resolve process without worrying about regressions.

https://github.com/graphql/graphql-js/blob/master/src/execution/__tests__/union-interface-test.js#L351

Extracting this from #304 as a separate issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants