Achieve full test coverage (#288)

Author: IvanGoncharov

.nycrc.yml

@@ -1,10 +1,14 @@
 all: true
 include:
-  - 'src/**/*'
-  - 'src/__tests__/starWarsData.js'
+  - 'src/'
 exclude: []
 clean: true
 temp-directory: 'coverage'
 report-dir: 'coverage'
 skip-full: true
 reporter: [json, html, text]
+check-coverage: true
+branches: 100
+lines: 100
+functions: 100
+statements: 100

src/__tests__/starWarsSchema.js

@@ -111,11 +111,11 @@ import {
 const { nodeInterface, nodeField } = nodeDefinitions(
   (globalId) => {
     const { type, id } = fromGlobalId(globalId);
-    if (type === 'Faction') {
-      return getFaction(id);
-    }
-    if (type === 'Ship') {
-      return getShip(id);
+    switch (type) {
+      case 'Faction':
+        return getFaction(id);
+      case 'Ship':
+        return getShip(id);
     }
   },
   (obj) => (obj.ships ? factionType : shipType),

src/mutation/__tests__/mutation.js

@@ -13,6 +13,10 @@ import {
 
 import { mutationWithClientMutationId } from '../mutation';
 
+function dummyResolve() {
+  return { result: 1 };
+}
+
 const simpleMutation = mutationWithClientMutationId({
   name: 'SimpleMutation',
   inputFields: {},
@@ -21,7 +25,7 @@ const simpleMutation = mutationWithClientMutationId({
       type: GraphQLInt,
     },
   },
-  mutateAndGetPayload: () => ({ result: 1 }),
+  mutateAndGetPayload: dummyResolve,
 });
 
 const simpleMutationWithDescription = mutationWithClientMutationId({
@@ -33,7 +37,7 @@ const simpleMutationWithDescription = mutationWithClientMutationId({
       type: GraphQLInt,
     },
   },
-  mutateAndGetPayload: () => ({ result: 1 }),
+  mutateAndGetPayload: dummyResolve,
 });
 
 const simpleMutationWithDeprecationReason = mutationWithClientMutationId({
@@ -44,7 +48,7 @@ const simpleMutationWithDeprecationReason = mutationWithClientMutationId({
       type: GraphQLInt,
     },
   },
-  mutateAndGetPayload: () => ({ result: 1 }),
+  mutateAndGetPayload: dummyResolve,
   deprecationReason: 'Just because',
 });
 

src/node/__tests__/global.js

@@ -50,14 +50,13 @@ const postData = {
 const { nodeField, nodeInterface } = nodeDefinitions(
   (globalId) => {
     const { type, id } = fromGlobalId(globalId);
-    if (type === 'User') {
-      return userData[id];
-    }
-    if (type === 'Photo') {
-      return photoData[id];
-    }
-    if (type === 'Post') {
-      return postData[id];
+    switch(type) {
+      case 'User':
+        return userData[id];
+      case 'Photo':
+        return photoData[id];
+      case 'Post':
+        return postData[id];
     }
   },
   (obj) => {
@@ -67,6 +66,8 @@ const { nodeField, nodeInterface } = nodeDefinitions(
     if (obj.photoId) {
       return photoType;
     }
+
+    // istanbul ignore else (Can't be reached)
     if (obj.text) {
       return postType;
     }

src/node/__tests__/node.js

@@ -51,6 +51,7 @@ const { nodeField, nodesField, nodeInterface } = nodeDefinitions(
     if (userData[obj.id]) {
       return userType;
     }
+    // istanbul ignore else (Can't be reached)
     if (photoData[obj.id]) {
       return photoType;
     }

src/node/plural.js

@@ -1,6 +1,6 @@
 // @flow strict
 
-import { GraphQLList, GraphQLNonNull, isNonNullType } from 'graphql';
+import { GraphQLList, GraphQLNonNull, getNullableType } from 'graphql';
 
 import type {
   GraphQLFieldConfig,
@@ -24,17 +24,15 @@ type PluralIdentifyingRootFieldConfig = {
 export function pluralIdentifyingRootField(
   config: PluralIdentifyingRootFieldConfig,
 ): GraphQLFieldConfig<mixed, mixed> {
-  let inputType = config.inputType;
-  if (isNonNullType(inputType)) {
-    inputType = inputType.ofType;
-  }
   return {
     description: config.description,
     type: new GraphQLList(config.outputType),
     args: {
       [config.argName]: {
         type: new GraphQLNonNull(
-          new GraphQLList(new GraphQLNonNull(inputType)),
+          new GraphQLList(
+            new GraphQLNonNull(getNullableType(config.inputType)),
+          ),
         ),
       },
     },