Add percent progress and height of peers to blocks field

This commit adds a conditional height of peers and percent progress
indicator to the blocks field on the overview screen to provide
more information during a wallet sync.

Author: jamescowens

src/qt/bitcoingui.cpp

@@ -980,6 +980,11 @@ void BitcoinGUI::setNumConnections(int n)
 
 void BitcoinGUI::setNumBlocks(int count, int nTotalBlocks)
 {
+    // Note: It is a really good question why the GUI uses a different standard than the core for determining whether
+    // the client is in sync.
+    // TODO: Review this and decide whether to converge the sync standards.
+    bool in_sync = false;
+
     // return if we have no connection to the network
     if (!clientModel || clientModel->getNumConnections() == 0)
     {
@@ -1023,6 +1028,7 @@ void BitcoinGUI::setNumBlocks(int count, int nTotalBlocks)
         labelBlocksIcon->setPixmap(GRC::ScaleStatusIcon(this, ":/icons/status_sync_done_" + sSheet));
 
         overviewPage->showOutOfSyncWarning(false);
+        in_sync = true;
         statusbarAlertsLabel->setText(clientModel->getStatusBarWarnings());
     }
     else
@@ -1031,6 +1037,7 @@ void BitcoinGUI::setNumBlocks(int count, int nTotalBlocks)
         tooltip = tr("Catching up...") + QString("<br>") + tooltip;
 
         overviewPage->showOutOfSyncWarning(true);
+        in_sync = false;
     }
 
     if(!text.isEmpty())
@@ -1043,7 +1050,7 @@ void BitcoinGUI::setNumBlocks(int count, int nTotalBlocks)
     tooltip = QString("<nobr>") + tooltip + QString("</nobr>");
 
     labelBlocksIcon->setToolTip(tooltip);
-    overviewPage->setHeight(count);
+    overviewPage->setHeight(count, nTotalBlocks, in_sync);
 }
 
 void BitcoinGUI::setDifficulty(double difficulty)

src/qt/overviewpage.cpp

@@ -276,9 +276,20 @@ void OverviewPage::setBalance(qint64 balance, qint64 stake, qint64 unconfirmedBa
     ui->immatureTextLabel->setVisible(showImmature);
 }
 
-void OverviewPage::setHeight(int height)
+void OverviewPage::setHeight(int height, int height_of_peers, bool in_sync)
 {
-    ui->blocksLabel->setText(QString::number(height));
+    QString text = QString::number(height);
+    unsigned int percent_progress = 0;
+
+    if (!in_sync && height_of_peers > 0 && height < height_of_peers) {
+        percent_progress = height * 100 / height_of_peers;
+
+        text += QString(" of %1 (%2\%)")
+                .arg(QString::number(height_of_peers))
+                .arg(QString::number(percent_progress));
+    }
+
+    ui->blocksLabel->setText(text);
 }
 
 void OverviewPage::setDifficulty(double difficulty, double net_weight)

src/qt/overviewpage.h

@@ -31,7 +31,7 @@ class OverviewPage : public QWidget
 
 public slots:
     void setBalance(qint64 balance, qint64 stake, qint64 unconfirmedBalance, qint64 immatureBalance);
-    void setHeight(int height);
+    void setHeight(int height, int height_of_peers, bool in_sync);
     void setDifficulty(double difficulty, double net_weight);
     void setCoinWeight(double coin_weight);
     void setCurrentPollTitle(const QString& title);