fix non-autofixable biome errors

Author: arafubeatbox

apps/app/src/server/service/config-manager/config-manager.spec.ts

@@ -32,7 +32,7 @@ describe('ConfigManager test', () => {
   });
 
   describe('updateConfig()', () => {
-    let loadConfigsSpy;
+    let loadConfigsSpy: ReturnType<typeof vi.spyOn>;
     beforeEach(async () => {
       loadConfigsSpy = vi.spyOn(configManager, 'loadConfigs');
       // Reset mocks
@@ -122,7 +122,7 @@ describe('ConfigManager test', () => {
   });
 
   describe('updateConfigs()', () => {
-    let loadConfigsSpy;
+    let loadConfigsSpy: ReturnType<typeof vi.spyOn>;
     beforeEach(async () => {
       loadConfigsSpy = vi.spyOn(configManager, 'loadConfigs');
       // Reset mocks

apps/app/src/server/service/s2s-messaging/nchan.ts

@@ -141,9 +141,9 @@ class NchanDelegator extends AbstractS2sMessagingService {
       logger.info('WebSocket client connected.');
     });
 
-    this.handlableList.forEach((handlable) =>
-      this.registerMessageHandlerToSocket(handlable),
-    );
+    this.handlableList.forEach((handlable) => {
+      this.registerMessageHandlerToSocket(handlable);
+    });
 
     this.socket = socket;
   }

apps/app/src/server/service/search-delegator/elasticsearch.ts

@@ -182,7 +182,7 @@ class ElasticsearchDelegator
   getConnectionInfo() {
     let indexName = 'crowi';
     let host: string | undefined;
-    let auth;
+    let auth: { username: string; password: string } | undefined;
 
     const elasticsearchUri = configManager.getConfig('app:elasticsearchUri');
 
@@ -642,7 +642,9 @@ class ElasticsearchDelegator
 
   deletePages(pages) {
     const body = [];
-    pages.forEach((page) => this.prepareBodyForDelete(body, page));
+    pages.forEach((page) => {
+      this.prepareBodyForDelete(body, page);
+    });
 
     logger.debug('deletePages(): Sending Request to ES', body);
     return this.client.bulk({

apps/app/src/server/service/search-delegator/private-legacy-pages.ts

@@ -85,16 +85,24 @@ class PrivateLegacyPagesDelegator
     const { match, not_match: notMatch, prefix, not_prefix: notPrefix } = terms;
 
     if (match.length > 0) {
-      match.forEach((m) => builder.addConditionToListByMatch(m));
+      for (const m of match) {
+        builder.addConditionToListByMatch(m);
+      }
     }
     if (notMatch.length > 0) {
-      notMatch.forEach((nm) => builder.addConditionToListByNotMatch(nm));
+      for (const nm of notMatch) {
+        builder.addConditionToListByNotMatch(nm);
+      }
     }
     if (prefix.length > 0) {
-      prefix.forEach((p) => builder.addConditionToListByStartWith(p));
+      for (const p of prefix) {
+        builder.addConditionToListByStartWith(p);
+      }
     }
     if (notPrefix.length > 0) {
-      notPrefix.forEach((np) => builder.addConditionToListByNotStartWith(np));
+      for (const np of notPrefix) {
+        builder.addConditionToListByNotStartWith(np);
+      }
     }
 
     return builder;

apps/app/src/server/service/slack-event-handler/link-shared.ts

@@ -68,7 +68,7 @@ export class LinkSharedEventHandler
       unfurlData.map(async (data: DataForUnfurl) => {
         const toUrl = urljoin(origin, data.id);
 
-        let targetUrl;
+        let targetUrl: string;
         if (data.isPermalink) {
           targetUrl = urljoin(origin, data.id);
         } else {
@@ -183,15 +183,16 @@ export class LinkSharedEventHandler
     const Page = this.crowi.model('Page');
     const unfurlData: DataForUnfurl[] = [];
 
-    pages.forEach((page) => {
+    for (const page of pages) {
       // not send non-public page
       if (page.grant !== PageGrant.GRANT_PUBLIC) {
-        return unfurlData.push({
+        unfurlData.push({
           isPublic: false,
           isPermalink,
           id: page._id.toString(),
           path: page.path,
         });
+        continue;
       }
 
       // public page
@@ -206,7 +207,7 @@ export class LinkSharedEventHandler
         updatedAt,
         commentCount,
       });
-    });
+    }
 
     return unfurlData;
   }