Skip to content

Tests rely on out-of-date envoy #754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aran opened this issue Dec 19, 2024 · 0 comments · Fixed by #760
Closed

Tests rely on out-of-date envoy #754

aran opened this issue Dec 19, 2024 · 0 comments · Fixed by #760

Comments

@aran
Copy link
Contributor

aran commented Dec 19, 2024

The tests use envoy 1.19.

https://github.com/grpc/grpc-dart/blob/master/.github/workflows/dart.yml#L82

test/grpc_web_server.dart uses a configuration file that is deprecated:

- name: envoy.filters.http.grpc_web

Modern versions of envoy require a change like this:

grpc/grpc-web#1220 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants