put health and etc. proto files in common #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

dapengzhang0 opened this issue May 20, 2016 · 1 comment

Member

dapengzhang0 commented May 20, 2016 •

edited

Loading

There have been multiple health.proto files in different places with minor different option fields:

https://github.com/grpc/grpc/blob/master/src/proto/grpc/health/v1/health.proto
https://github.com/grpc/grpc-java/blob/master/services/src/main/proto/health.proto
https://github.com/grpc/grpc-go/blob/master/health/grpc_health_v1/health.proto

As discussed in grpc/grpc-java#1821 @ejona86 @carl-mastrangelo @buchgr @ctiller, it may be better to have a synced up version in grpc/grpc-common

Contributor

carl-mastrangelo commented May 20, 2016

+1

nicolasnoble closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment