-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Add rest endpoint annotations for health.proto #4356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@iaguera Do you mean adding the http annotations to the proto? |
Yes :) |
@carl-mastrangelo is there any problem to submit a pull request with that change? (If not) is there any tip or something procedures to submit the code? |
Main issue is dependencies. In order to compile that proto, we would need to pull in a dependency on googleapis. |
Health.proto is shared with other repositories. We need to keep them all consistent. But other than that, seems fine. But it is probably hard to add those annotations to the main grpc/grpc repo. I'd be best to start there (and that is the canonical source of health.proto). |
Please answer these questions before submitting your issue.
What version of gRPC are you using?
Using gRPC 1.9.0
What did you expect to see?
If it were possible to implement the health.proto service as REST interface too, it would minimize the duplication and generation of protofiles when using together with the repository of gRPC-gateway( https://github.com/grpc-ecosystem/grpc-gateway).
The text was updated successfully, but these errors were encountered: