Skip to content

Add rest endpoint annotations for health.proto #4356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iagoquirino opened this issue Apr 19, 2018 · 5 comments
Open

Add rest endpoint annotations for health.proto #4356

iagoquirino opened this issue Apr 19, 2018 · 5 comments

Comments

@iagoquirino
Copy link

Please answer these questions before submitting your issue.

What version of gRPC are you using?

Using gRPC 1.9.0

What did you expect to see?

If it were possible to implement the health.proto service as REST interface too, it would minimize the duplication and generation of protofiles when using together with the repository of gRPC-gateway( https://github.com/grpc-ecosystem/grpc-gateway).

@carl-mastrangelo
Copy link
Contributor

@iaguera Do you mean adding the http annotations to the proto?

@iagoquirino
Copy link
Author

Yes :)

@iagoquirino
Copy link
Author

@carl-mastrangelo is there any problem to submit a pull request with that change?

(If not) is there any tip or something procedures to submit the code?

@carl-mastrangelo
Copy link
Contributor

Main issue is dependencies. In order to compile that proto, we would need to pull in a dependency on googleapis.

@ejona86
Copy link
Member

ejona86 commented Apr 24, 2018

Health.proto is shared with other repositories. We need to keep them all consistent. But other than that, seems fine. But it is probably hard to add those annotations to the main grpc/grpc repo. I'd be best to start there (and that is the canonical source of health.proto).

@ejona86 ejona86 changed the title Increment rest endpoint for health.proto Add rest endpoint annotations for health.proto Apr 24, 2018
@ejona86 ejona86 added this to the Unscheduled milestone Apr 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants