Skip to content

Add RequestType and ResponseType Metadata #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Jmoore1127 opened this issue Jun 21, 2018 · 0 comments · Fixed by #703
Closed

Add RequestType and ResponseType Metadata #407

Jmoore1127 opened this issue Jun 21, 2018 · 0 comments · Fixed by #703

Comments

@Jmoore1127
Copy link

Jmoore1127 commented Jun 21, 2018

Is your feature request related to a problem? Please describe.

I am attempting an upgrade of some tooling that was previously using grpc.load(...) to use the new proto-loader. The parsed proto the is returned is now much simpler and easier to use in many ways. However, the RequestType and ResponseType information is no longer available in proto-loader. The tooling I am working with uses this information in order to produce sample json objects for the user.

Describe the solution you'd like

I would like to add this metadata to the method definition returned from createMethodDefinition in grpc-protobufjs/src/index.ts so that the tooling has access to this information.

Additional context

I have submitted a PR with a basic implementation.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants