Skip to content

Modules that have names that are also Go keywords don't work #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alanjds opened this issue Aug 21, 2018 · 1 comment
Open

Modules that have names that are also Go keywords don't work #26

alanjds opened this issue Aug 21, 2018 · 1 comment
Labels
imported Imported from google/grumpy

Comments

@alanjds
Copy link

alanjds commented Aug 21, 2018

google#108 opened by @trotterdylan on 13 Jan 2017

E.g. the struct module has to declare package struct at the top of the file, which is a compilation error. The obvious options seem to be:

  1. Always prefix Grumpy package names so that there is never a keyword collision
  2. Have special handling in grumpc that changes the way imports work for modules that are named the same as a Go keyword.
@alanjds
Copy link
Author

alanjds commented Aug 21, 2018

Comment by S-YOU
Friday Jan 13, 2017 at 17:01 GMT


For hand-written codes that using grumpy will have less impact with 2, I guess.
struct is not ok, but copy is ok, so may be not so many there.

@alanjds alanjds added the imported Imported from google/grumpy label Aug 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
imported Imported from google/grumpy
Projects
None yet
Development

No branches or pull requests

1 participant