Skip to content

Commit 81639f4

Browse files
iskakaushikgspencergoog
authored andcommitted
[macOS] flutter_desktop_darwin_unittests can be enabled for all runtime modes (flutter#21681)
1 parent c5e31af commit 81639f4

File tree

2 files changed

+1
-4
lines changed

2 files changed

+1
-4
lines changed

shell/platform/darwin/macos/framework/Source/FlutterEngine.mm

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -267,6 +267,7 @@ - (BOOL)runWithEntrypoint:(NSString*)entrypoint {
267267
flutterArguments.command_line_argv = argv.size() > 0 ? argv.data() : nullptr;
268268
flutterArguments.platform_message_callback = (FlutterPlatformMessageCallback)OnPlatformMessage;
269269
flutterArguments.custom_dart_entrypoint = entrypoint.UTF8String;
270+
flutterArguments.shutdown_dart_vm_when_done = true;
270271
static size_t sTaskRunnerIdentifiers = 0;
271272
const FlutterTaskRunnerDescription cocoa_task_runner_description = {
272273
.struct_size = sizeof(FlutterTaskRunnerDescription),

testing/run_tests.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -147,10 +147,6 @@ def RunCCTests(build_dir, filter):
147147
# These unit-tests are Objective-C and can only run on Darwin.
148148
if IsMac():
149149
RunEngineExecutable(build_dir, 'flutter_channels_unittests', filter, shuffle_flags)
150-
151-
# These tests can only be run on Darwin on debug mode.
152-
# See: https://github.com/flutter/flutter/issues/66664
153-
if IsMac() and ('debug' in build_dir):
154150
RunEngineExecutable(build_dir, 'flutter_desktop_darwin_unittests', filter, shuffle_flags)
155151

156152
# https://github.com/flutter/flutter/issues/36296

0 commit comments

Comments
 (0)