Breaking: Remove passthrough option & infer readable or passthrough

Author: phated

README.md

@@ -96,14 +96,6 @@ Type: `Boolean`
 
 Default: `true`
 
-##### `options.passthrough`
-
-Allows `.src` to be used in the middle of a pipeline (using a duplex stream) which passes through all objects received and adds all files globbed to the stream.
-
-Type: `Boolean`
-
-Default: `false`
-
 ##### `options.sourcemaps`
 
 Enables sourcemap support on files passed through the stream.  Will load inline sourcemaps and resolve sourcemap links from files. Uses [gulp-sourcemaps] under the hood.

lib/src/index.js

@@ -1,21 +1,15 @@
 'use strict';
 
-var pumpify = require('pumpify');
-var through2 = require('through2');
 var gs = require('glob-stream');
-var duplexify = require('duplexify');
-var merge = require('merge-stream');
+var pumpify = require('pumpify');
+var prepare = require('vinyl-prepare');
+var toThrough = require('to-through');
 var isValidGlob = require('is-valid-glob');
-var valueOrFunction = require('value-or-function');
-var koalas = require('koalas');
 
-var prepare = require('vinyl-prepare');
 var sourcemap = require('./sourcemap');
 var readContents = require('./read-contents');
 var resolveSymlinks = require('./resolve-symlinks');
 
-var boolean = valueOrFunction.boolean;
-
 function src(glob, opt) {
   if (!opt) {
     opt = {};
@@ -25,14 +19,10 @@ function src(glob, opt) {
     throw new Error('Invalid glob argument: ' + glob);
   }
 
-  var passthroughOpt = koalas(boolean(opt.passthrough), false);
-
   // Don't pass `read` option on to through2
   opt.readFile = opt.read;
   opt.read = undefined;
 
-  var inputStream;
-
   var streams = [
     gs.create(glob, opt),
     resolveSymlinks(opt),
@@ -43,13 +33,7 @@ function src(glob, opt) {
 
   var outputStream = pumpify.obj(streams);
 
-  if (passthroughOpt) {
-    inputStream = through2.obj(opt);
-    outputStream = merge(outputStream, inputStream);
-    outputStream = duplexify.obj(inputStream, outputStream);
-  }
-
-  return outputStream;
+  return toThrough(outputStream);
 }
 
 

package.json

@@ -41,6 +41,7 @@
     "strip-bom-stream": "^1.0.0",
     "through2": "^2.0.0",
     "through2-filter": "^2.0.0",
+    "to-through": "^2.0.0",
     "value-or-function": "^2.0.0",
     "vinyl": "^2.0.0",
     "vinyl-prepare": "^0.1.1",

test/src.js

@@ -105,7 +105,7 @@ describe('.src()', function() {
     ], assert);
   });
 
-  it.skip('passes through writes', function(done) {
+  it('passes through writes', function(done) {
     var file = new File({
       base: inputBase,
       path: inputPath,
@@ -328,7 +328,7 @@ describe('.src()', function() {
     ], done);
   });
 
-  it('passes files through', function(done) {
+  it('can be used as a through stream and adds new files to the end', function(done) {
     var file = new File({
       base: inputBase,
       path: inputPath,
@@ -343,7 +343,19 @@ describe('.src()', function() {
 
     pipe([
       from.obj([file]),
-      vfs.src(inputPath, { passthrough: true }),
+      vfs.src(inputPath),
+      concat(assert),
+    ], done);
+  });
+
+  it('can be used at beginning and in the middle', function(done) {
+    function assert(files) {
+      expect(files.length).toEqual(2);
+    }
+
+    pipe([
+      vfs.src(inputPath),
+      vfs.src(inputPath),
       concat(assert),
     ], done);
   });