Issue with omitempty

[ERobsham]

Less of an issue, and more of an FYI. I have been keeping tabs on the (un)marshaling/(de)encoding issue with omitempty, and it looks like they have a adjacent proposal that may provide a workable solution:

golang/go#5901

Didn't see anywhere else to leave a comment about this, and I figured it is relevant to this project in particular (I know its relevant to my usage of this project! Thanks by the way!)

[guregu]

That's great to hear, thanks! I'll definitely look into supporting this when it gets released (maybe with a function in the library that users can register if they need omitempty support?)

[PumpkinSeed]

Also in the meantime I just created a copy of the current json package of Go and I added an interface check for IsZero methods. https://github.com/PumpkinSeed/json

[rts-gordon]

@guregu

Is this issue any progress? It is not updated for several years.

[guregu]

@guregu

Is this issue any progress? It is not updated for several years.

It’s a problem with the Go standard library. There is nothing this package can do until encoding/json changes.

[sashahilton00]

FYI the upstream issue causing this is due to have a patch merged imminently: https://go-review.googlesource.com/c/go/+/615676#message-bc498f053e2e3af9f415c67dd7327609b10b4ac4

[cspeidel]

Go 1.24 has been released with new omitzero support.

[guregu]

Yay. Nice to finally update that bit of the README.md after 10 years, haha.

If anyone sees this from Google, etc., update to Go 1.24+ and use ,omitzero instead of omitempty to support this package's types.