Skip to content

Commit 010cdfe

Browse files
committed
fix: enable debug by default
1 parent d1ea877 commit 010cdfe

7 files changed

Lines changed: 10 additions & 10 deletions

File tree

src/app.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ export function createApp (options: AppOptions = {}): App {
1212
// @ts-ignore
1313
const app: Partial<App> = function (req: IncomingMessage, res: ServerResponse) {
1414
return _handle(req, res)
15-
.catch((err: Error | any) => { sendError(res, err, options.debug) })
15+
.catch((err: Error | any) => { sendError(res, err, undefined, options.debug) })
1616
}
1717

1818
app.stack = stack

src/utils.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ export function defaultContentType (res: ServerResponse, type: string) {
1717
}
1818
}
1919

20-
export function sendError (res: ServerResponse, error: Error | string, debug?: boolean, code?: number) {
20+
export function sendError (res: ServerResponse, error: Error | string, code?: number, debug: boolean = true) {
2121
res.statusCode = code ||
2222
(res.statusCode !== 200 && res.statusCode) ||
2323
// @ts-ignore

test/app.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ describe('app', () => {
66
let request: SuperTest<Test>
77

88
beforeEach(() => {
9-
app = createApp()
9+
app = createApp({ debug: false })
1010
request = supertest(app)
1111
})
1212

test/e2e.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ describe('server', () => {
1010
let server: Server
1111

1212
beforeEach(async () => {
13-
app = createApp()
13+
app = createApp({ debug: false })
1414
server = new Server(app)
1515
const port = await getPort()
1616
server.listen(port)

test/integrations.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ describe('integrations with other frameworks', () => {
99
let request: SuperTest<Test>
1010

1111
beforeEach(() => {
12-
app = createApp()
12+
app = createApp({ debug: false })
1313
request = supertest(app)
1414
})
1515

test/lazy.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ describe('lazy loading', () => {
88
let request: SuperTest<Test>
99

1010
beforeEach(() => {
11-
app = createApp()
11+
app = createApp({ debug: false })
1212
request = supertest(app)
1313
})
1414

test/utils.test.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ describe('', () => {
88
let request: SuperTest<Test>
99

1010
beforeEach(() => {
11-
app = createApp()
11+
app = createApp({ debug: false })
1212
request = supertest(app)
1313
})
1414

@@ -24,7 +24,7 @@ describe('', () => {
2424

2525
describe('sendError', () => {
2626
it('logs errors', async () => {
27-
app.use((_req, res) => sendError(res, 'Unprocessable', undefined, 422))
27+
app.use((_req, res) => sendError(res, 'Unprocessable', 422))
2828
const result = await request.get('/')
2929

3030
expect(result.status).toBe(422)
@@ -33,14 +33,14 @@ describe('', () => {
3333

3434
describe('sendError', () => {
3535
it('returns errors', async () => {
36-
app.use((_req, res) => sendError(res, 'Unprocessable', undefined, 422))
36+
app.use((_req, res) => sendError(res, 'Unprocessable', 422))
3737
const result = await request.get('/')
3838

3939
expect(result.status).toBe(422)
4040
})
4141

4242
it('logs errors in debug mode', async () => {
43-
app.use((_req, res) => sendError(res, 'Unprocessable', true, 422))
43+
app.use((_req, res) => sendError(res, 'Unprocessable', 422, true))
4444
const result = await request.get('/')
4545

4646
expect(result.status).toBe(422)

0 commit comments

Comments
 (0)