Skip to content

Commit fb79f41

Browse files
feat: support auto complete for http header names (#542)
Co-authored-by: Pooya Parsa <pooya@pi0.io>
1 parent 9e81e4e commit fb79f41

3 files changed

Lines changed: 26 additions & 7 deletions

File tree

src/types.ts

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,4 +96,14 @@ export type EventHandlerObject<
9696

9797
export type LazyEventHandler = () => EventHandler | Promise<EventHandler>;
9898

99-
export type RequestHeaders = { [name: string]: string | undefined };
99+
export type RequestHeaders = Partial<
100+
Record<HTTPHeaderName, string | undefined>
101+
>;
102+
103+
// prettier-ignore
104+
type _HTTPHeaderName = "WWW-Authenticate" | "Authorization" | "Proxy-Authenticate" | "Proxy-Authorization" | "Age" | "Cache-Control" | "Clear-Site-Data" | "Expires" | "Pragma" | "Accept-CH" | "Critical-CH" | "Sec-CH-UA" | "Sec-CH-UA-Arch" | "Sec-CH-UA-Bitness" | "Sec-CH-UA-Full-Version-List" | "Sec-CH-UA-Mobile" | "Sec-CH-UA-Model" | "Sec-CH-UA-Platform" | "Sec-CH-UA-Platform-Version" | "Sec-CH-UA-Prefers-Color-Scheme" | "Sec-CH-UA-Prefers-Reduced-Motion" | "Downlink" | "ECT" | "RTT" | "Save-Data" | "Last-Modified" | "ETag" | "If-Match" | "If-None-Match" | "If-Modified-Since" | "If-Unmodified-Since" | "Vary" | "Connection" | "Keep-Alive" | "Accept" | "Accept-Encoding" | "Accept-Language" | "Expect" | "Max-Forwards" | "Cookie" | "Set-Cookie" | "Access-Control-Allow-Origin" | "Access-Control-Allow-Credentials" | "Access-Control-Allow-Headers" | "Access-Control-Allow-Methods" | "Access-Control-Expose-Headers" | "Access-Control-Max-Age" | "Access-Control-Request-Headers" | "Access-Control-Request-Method" | "Origin" | "Timing-Allow-Origin" | "Content-Disposition" | "Content-Length" | "Content-Type" | "Content-Encoding" | "Content-Language" | "Content-Location" | "Forwarded" | "X-Forwarded-For" | "X-Forwarded-Host" | "X-Forwarded-Proto" | "Via" | "Location" | "Refresh" | "From" | "Host" | "Referer" | "Referrer-Policy" | "User-Agent" | "Allow" | "Server" | "Accept-Ranges" | "Range" | "If-Range" | "Content-Range" | "Cross-Origin-Embedder-Policy" | "Cross-Origin-Opener-Policy" | "Cross-Origin-Resource-Policy" | "Content-Security-Policy" | "Content-Security-Policy-Report-Only" | "Expect-CT" | "Origin-Isolation" | "Permissions-Policy" | "Strict-Transport-Security" | "Upgrade-Insecure-Requests" | "X-Content-Type-Options" | "X-Frame-Options" | "X-Permitted-Cross-Domain-Policies" | "X-Powered-By" | "X-XSS-Protection" | "Sec-Fetch-Site" | "Sec-Fetch-Mode" | "Sec-Fetch-User" | "Sec-Fetch-Dest" | "Sec-Purpose" | "Service-Worker-Navigation-Preload" | "Last-Event-ID" | "NEL" | "Ping-From" | "Ping-To" | "Report-To" | "Transfer-Encoding" | "TE" | "Trailer" | "Sec-WebSocket-Key" | "Sec-WebSocket-Extensions" | "Sec-WebSocket-Accept" | "Sec-WebSocket-Protocol" | "Sec-WebSocket-Version" | "Accept-Push-Policy" | "Accept-Signature" | "Alt-Svc" | "Alt-Used" | "Date" | "Early-Data" | "Link" | "Push-Policy" | "Retry-After" | "Signature" | "Signed-Headers" | "Server-Timing" | "Service-Worker-Allowed" | "SourceMap" | "Upgrade" | "X-DNS-Prefetch-Control" | "X-Pingback" | "X-Requested-With" | "X-Robots-Tag";
105+
106+
export type HTTPHeaderName =
107+
| _HTTPHeaderName
108+
| Lowercase<_HTTPHeaderName>
109+
| (string & {}); // eslint-disable-line @typescript-eslint/ban-types

src/utils/request.ts

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,11 @@
11
import { getQuery as _getQuery } from "ufo";
22
import { createError } from "../error";
3-
import type { HTTPMethod, InferEventInput, RequestHeaders } from "../types";
3+
import type {
4+
HTTPHeaderName,
5+
HTTPMethod,
6+
InferEventInput,
7+
RequestHeaders,
8+
} from "../types";
49
import type { H3Event } from "../event";
510
import { validateData, ValidateFunction } from "./internal/validate";
611
import { getRequestWebStream } from "./body";
@@ -94,7 +99,7 @@ export const getHeaders = getRequestHeaders;
9499

95100
export function getRequestHeader(
96101
event: H3Event,
97-
name: string,
102+
name: HTTPHeaderName,
98103
): RequestHeaders[string] {
99104
const headers = getRequestHeaders(event);
100105
const value = headers[name.toLowerCase()];

src/utils/response.ts

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ import type { OutgoingMessage } from "node:http";
22
import type { Readable } from "node:stream";
33
import type { Socket } from "node:net";
44
import type { H3Event } from "../event";
5+
import type { HTTPHeaderName } from "../types";
56
import { MIMES } from "./consts";
67
import { sanitizeStatusCode, sanitizeStatusMessage } from "./sanitize";
78
import { splitCookiesString } from "./cookie";
@@ -94,7 +95,7 @@ export function getResponseHeaders(
9495

9596
export function getResponseHeader(
9697
event: H3Event,
97-
name: string,
98+
name: HTTPHeaderName,
9899
): ReturnType<H3Event["res"]["getHeader"]> {
99100
return event.node.res.getHeader(name);
100101
}
@@ -112,7 +113,7 @@ export const setHeaders = setResponseHeaders;
112113

113114
export function setResponseHeader(
114115
event: H3Event,
115-
name: string,
116+
name: HTTPHeaderName,
116117
value: Parameters<OutgoingMessage["setHeader"]>[1],
117118
): void {
118119
event.node.res.setHeader(name, value);
@@ -133,7 +134,7 @@ export const appendHeaders = appendResponseHeaders;
133134

134135
export function appendResponseHeader(
135136
event: H3Event,
136-
name: string,
137+
name: HTTPHeaderName,
137138
value: string,
138139
): void {
139140
let current = event.node.res.getHeader(name);
@@ -172,7 +173,10 @@ export function clearResponseHeaders(
172173
}
173174
}
174175

175-
export function removeResponseHeader(event: H3Event, name: string): void {
176+
export function removeResponseHeader(
177+
event: H3Event,
178+
name: HTTPHeaderName,
179+
): void {
176180
return event.node.res.removeHeader(name);
177181
}
178182

0 commit comments

Comments
 (0)