fix: context type for CompatibilityRequestProps#164
Conversation
The changes to make the context extendable by userland types in PR #124 were insufficient to apply the type also to the `CompatibilityEvent`.
context type for CompatibilityRequestProps
context type for CompatibilityRequestPropscontext type for CompatibilityRequestProps
pi0
approved these changes
Aug 23, 2022
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes in PR #124 to make the
H3EventContextextendable by userland types were insufficient to apply the type also to theCompatibilityEvent, which is the type of events for event handlers. I always gotcontext.user: anywhen only declaring the context interface:Because
CompatibilityEventcan also be anIncomingMessage, which extends theCompatibilityRequestProps, which in turn still declares an un-extendablecontext: Record<string, any>. This givesCompatibilityEvent.context: H3EventContext | Record<string, any>, which givesanyfor all properties, even ifH3EventContextis typed.