Conversation
Member
|
Very nice thought. However, it looks like this adds a hard dependency on node, which we would want to avoid. Maybe something other than |
Contributor
Author
Hum, that's true. Using deno or web workers would rely on ReadableStream which is the new standard. This uses the former node streams. Instead we can rely on the new stream implementation, so we can check over The caveat is that the feature is new and require node v16, what do you think? Edit: unfortunately we can not use pipeTo on http responses for now, even with node 17 |
pi0
reviewed
Mar 15, 2022
pi0
reviewed
Mar 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows to pipe readable streams returned from middlewares!
I also set the default
content-typeheader used for buffers and streams totext/htmlassuming most of time it would be used to pipe html response. We could useapplication/octet-streaminstead, but it would require to explicitly setcontent-typeon each responses.