Unskip g_suite_account_service/create_spec.rb and replace fixtures with factories (#3046)

#3008

Similar to #3043, move the production specific skip lower in the stack so that the rest of the service's API is upheld.

* Unskip test

Move environment check into specific client wrappers
Because email has text and html, must use body.encoded https://stackoverflow.com/questions/29454102/in-rails-why-is-my-mail-body-empty-only-in-my-test
Fix variables (event was missing, @g_suite is actually g_suite)

* Replace fixtures with factories

Author: albertchae

app/services/g_suite_account_service/create.rb

@@ -14,11 +14,6 @@ def initialize(g_suite:, current_user:,
     end
 
     def run
-      unless Rails.env.production?
-        puts "☣️ In production, we would currently be creating the GSuite on Google Admin ☣️"
-        return
-      end
-
       ActiveRecord::Base.transaction do
         # 1. Create local account
         g_suite_account.save!

app/services/partners/google/g_suite/create_user.rb

@@ -18,6 +18,11 @@ def initialize(given_name:, family_name:, password:, primary_email:, recovery_em
         end
 
         def run
+          unless Rails.env.production?
+            puts "☣️ In production, we would currently be creating the GSuite on Google Admin ☣️"
+            return
+          end
+
           directory_client.insert_user(user_object)
         end
 

app/services/partners/google/g_suite/org_unit.rb

@@ -11,6 +11,11 @@ def initialize(org_unit_path:)
         end
 
         def run
+          unless Rails.env.production?
+            puts "☣️ In production, we would currently be creating the GSuite on Google Admin ☣️"
+            return
+          end
+
           directory_client.get_org_unit(gsuite_customer_id, org_unit_path_without_leading_slash)
         rescue ::Google::Apis::ClientError => e
           # re-raise unless 404

spec/services/g_suite_account_service/create_spec.rb

@@ -2,19 +2,18 @@
 
 require "rails_helper"
 
-RSpec.describe GSuiteAccountService::Create, type: :model, skip: true do
-  fixtures "users", "events", "g_suites"
-
-  let(:g_suite) { g_suites(:g_suite1) }
-  let(:current_user) { users(:user1) }
+RSpec.describe GSuiteAccountService::Create, type: :model do
+  let(:g_suite) { create(:g_suite, domain: "event.example.com") }
+  let(:current_user) { create(:user) }
+  let(:event) { create(:event) }
 
   let(:backup_email) { "[email protected]" }
   let(:address) { "address" }
   let(:first_name) { "First" }
   let(:last_name) { "Last" }
 
   let(:remote_org_unit) do
-    ou_name = "##{event.id} G##{@g_suite.id}"
+    ou_name = "##{event.id} G##{g_suite.id}"
     double("remoteOrgUnit", name: ou_name, org_unit_id: "id:1234", org_unit_path: "/Events/#{ou_name}")
   end
 
@@ -54,8 +53,8 @@
 
     expect(mail.to).to eql(["[email protected]"])
     expect(mail.subject).to include("Your Google Workspace account via Bank is ready")
-    expect(mail.body).to include("address@event1.example.com")
-    expect(mail.body).to include(g_suite_account.initial_password)
+    expect(mail.body.encoded).to include("address@event.example.com")
+    expect(mail.body.encoded).to include(g_suite_account.initial_password)
   end
 
   context "when remote org unit does not exist" do
@@ -79,7 +78,7 @@
     it "assigns remote_org_unit_path" do
       expect do
         service.run
-      end.to change(g_suite.reload, :remote_org_unit_path).to("/Events/##{event.id} G##{@g_suite.id}")
+      end.to change(g_suite.reload, :remote_org_unit_path).to("/Events/##{event.id} G##{g_suite.id}")
     end
   end
 
@@ -94,7 +93,7 @@
       end.not_to change(GSuiteAccount, :count)
     end
 
-    it "raises an errro" do
+    it "raises an error" do
       expect do
         service.run
       end.to raise_error(ArgumentError)
@@ -106,7 +105,7 @@
       it "builds" do
         result = service.send(:full_email_address)
 
-        expect(result).to eql("address@event1.example.com")
+        expect(result).to eql("address@event.example.com")
       end
     end
   end