Skip to content

Commit 9b6eae3

Browse files
author
David Kilzer
committed
Build fix #3: Adopt attribution AVCaptureSession SPI for GPU process
https://bugs.webkit.org/show_bug.cgi?id=231621 <rdar://problem/80748535> Unreviewed build fix. Source/WebCore/PAL: * pal/spi/cocoa/TCCSPI.h: - Use HAVE(TCC_IOS_14_BIG_SUR_SPI). Source/WebKit: * Shared/Cocoa/TCCSoftLink.h: (tcc_identity_create): * Shared/Cocoa/TCCSoftLink.mm: (tcc_identity_create): - Use HAVE(TCC_IOS_14_BIG_SUR_SPI). Source/WTF: * wtf/PlatformHave.h: (HAVE_TCC_IOS_14_BIG_SUR_SPI): Add. - Used for TCC.framework SPI available in iOS 14 and macOS 11 Big Sur and later. Canonical link: https://commits.webkit.org/243138@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@284344 268f45cc-cd09-0410-ab3c-d52691b4dbfc
1 parent e1fe610 commit 9b6eae3

File tree

7 files changed

+50
-0
lines changed

7 files changed

+50
-0
lines changed

Source/WTF/ChangeLog

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,16 @@
1+
2021-10-17 David Kilzer <[email protected]>
2+
3+
Build fix #3: Adopt attribution AVCaptureSession SPI for GPU process
4+
https://bugs.webkit.org/show_bug.cgi?id=231621
5+
<rdar://problem/80748535>
6+
7+
Unreviewed build fix.
8+
9+
* wtf/PlatformHave.h:
10+
(HAVE_TCC_IOS_14_BIG_SUR_SPI): Add.
11+
- Used for TCC.framework SPI available in iOS 14 and macOS 11
12+
Big Sur and later.
13+
114
2021-10-17 David Kilzer <[email protected]>
215

316
Add tests for WTF::OSObjectPtr/adoptOSObject in Cocoa with and without ARC

Source/WTF/wtf/PlatformHave.h

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -765,6 +765,12 @@
765765
#endif
766766
#endif
767767

768+
#if (PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 140000) || (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 110000)
769+
#if !defined(HAVE_TCC_IOS_14_BIG_SUR_SPI)
770+
#define HAVE_TCC_IOS_14_BIG_SUR_SPI 1
771+
#endif
772+
#endif
773+
768774
#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 120000
769775
#if !defined(HAVE_SPEECHSYNTHESIS_MONTEREY_SPI)
770776
#define HAVE_SPEECHSYNTHESIS_MONTEREY_SPI 1

Source/WebCore/PAL/ChangeLog

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,14 @@
1+
2021-10-17 David Kilzer <[email protected]>
2+
3+
Build fix #3: Adopt attribution AVCaptureSession SPI for GPU process
4+
https://bugs.webkit.org/show_bug.cgi?id=231621
5+
<rdar://problem/80748535>
6+
7+
Unreviewed build fix.
8+
9+
* pal/spi/cocoa/TCCSPI.h:
10+
- Use HAVE(TCC_IOS_14_BIG_SUR_SPI).
11+
112
2021-10-15 Ross Kirsling <[email protected]>
213

314
Realize Mac CMake build of WebCore and WebKit

Source/WebCore/PAL/pal/spi/cocoa/TCCSPI.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,10 @@ typedef enum {
3636
kTCCAccessPreflightDenied,
3737
} TCCAccessPreflightResult;
3838

39+
#if HAVE(TCC_IOS_14_BIG_SUR_SPI)
3940
typedef uint64_t tcc_identity_type_t;
4041
constexpr tcc_identity_type_t TCC_IDENTITY_CODE_BUNDLE_ID = 0;
4142
typedef void* tcc_identity_t;
43+
#endif // HAVE(TCC_IOS_14_BIG_SUR_SPI)
4244

4345
#endif

Source/WebKit/ChangeLog

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,17 @@
1+
2021-10-17 David Kilzer <[email protected]>
2+
3+
Build fix #3: Adopt attribution AVCaptureSession SPI for GPU process
4+
https://bugs.webkit.org/show_bug.cgi?id=231621
5+
<rdar://problem/80748535>
6+
7+
Unreviewed build fix.
8+
9+
* Shared/Cocoa/TCCSoftLink.h:
10+
(tcc_identity_create):
11+
* Shared/Cocoa/TCCSoftLink.mm:
12+
(tcc_identity_create):
13+
- Use HAVE(TCC_IOS_14_BIG_SUR_SPI).
14+
115
2021-10-17 David Kilzer <[email protected]>
216

317
Follow-up: WebKit::LocalConnection::createCredentialPrivateKey leaks an NSMutableDictionary

Source/WebKit/Shared/Cocoa/TCCSoftLink.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,5 +43,7 @@ SOFT_LINK_FUNCTION_FOR_HEADER(WebKit, TCC, TCCAccessPreflight, TCCAccessPrefligh
4343
#define TCCAccessPreflight WebKit::softLink_TCC_TCCAccessPreflight
4444
SOFT_LINK_FUNCTION_FOR_HEADER(WebKit, TCC, TCCAccessPreflightWithAuditToken, TCCAccessPreflightResult, (CFStringRef service, audit_token_t token, CFDictionaryRef options), (service, token, options))
4545
#define TCCAccessPreflightWithAuditToken WebKit::softLink_TCC_TCCAccessPreflightWithAuditToken
46+
#if HAVE(TCC_IOS_14_BIG_SUR_SPI)
4647
SOFT_LINK_FUNCTION_FOR_HEADER(WebKit, TCC, tcc_identity_create, tcc_identity_t, (tcc_identity_type_t type, const char * identifier), (type, identifier));
4748
#define tcc_identity_create WebKit::softLink_TCC_tcc_identity_create
49+
#endif // HAVE(TCC_IOS_14_BIG_SUR_SPI)

Source/WebKit/Shared/Cocoa/TCCSoftLink.mm

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,4 +40,6 @@
4040
SOFT_LINK_FUNCTION_FOR_SOURCE(WebKit, TCC, TCCAccessCheckAuditToken, Boolean, (CFStringRef service, audit_token_t auditToken, CFDictionaryRef options), (service, auditToken, options))
4141
SOFT_LINK_FUNCTION_FOR_SOURCE(WebKit, TCC, TCCAccessPreflight, TCCAccessPreflightResult, (CFStringRef service, CFDictionaryRef options), (service, options))
4242
SOFT_LINK_FUNCTION_FOR_SOURCE(WebKit, TCC, TCCAccessPreflightWithAuditToken, TCCAccessPreflightResult, (CFStringRef service, audit_token_t token, CFDictionaryRef options), (service, token, options))
43+
#if HAVE(TCC_IOS_14_BIG_SUR_SPI)
4344
SOFT_LINK_FUNCTION_FOR_SOURCE(WebKit, TCC, tcc_identity_create, tcc_identity_t, (tcc_identity_type_t type, const char * identifier), (type, identifier));
45+
#endif // HAVE(TCC_IOS_14_BIG_SUR_SPI)

0 commit comments

Comments
 (0)