Skip to content

Commit 785a63e

Browse files
committed
Test on Node 18 and drop EOL Node 10
* Updated lock-file to fix npm/cli#4859. * Updated integration-tests to webpack 5 to fix webpack/webpack#14532. * Added `mode` to webpack-integration-tests to avoid the warning `The 'mode' option has not been set...`. * Replaced outdated `grunt-bg-shell`-package to get rid of coffee-script warnings
1 parent 903ca50 commit 785a63e

File tree

11 files changed

+843
-3420
lines changed

11 files changed

+843
-3420
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ jobs:
5858
matrix:
5959
operating-system: ['ubuntu-latest', 'windows-latest']
6060
# https://nodejs.org/en/about/releases/
61-
node-version: ['10', '12', '14', '16', '17']
61+
node-version: ['12', '14', '16', '18']
6262

6363
steps:
6464
- name: Checkout
@@ -78,8 +78,6 @@ jobs:
7878
run: npm run test
7979

8080
- name: Test (Integration)
81-
# https://github.com/webpack/webpack/issues/14532
82-
if: ${{ matrix.node-version != '17' }}
8381
run: |
8482
cd ./tests/integration/rollup-test && ./test.sh && cd -
8583
cd ./tests/integration/webpack-babel-test && ./test.sh && cd -

Gruntfile.js

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -111,11 +111,9 @@ module.exports = function(grunt) {
111111
}
112112
},
113113

114-
bgShell: {
114+
shell: {
115115
integrationTests: {
116-
cmd: './tests/integration/run-integration-tests.sh',
117-
bg: false,
118-
fail: true
116+
command: './tests/integration/run-integration-tests.sh'
119117
}
120118
},
121119

@@ -139,7 +137,7 @@ module.exports = function(grunt) {
139137
grunt.loadNpmTasks('grunt-contrib-uglify');
140138
grunt.loadNpmTasks('grunt-contrib-watch');
141139
grunt.loadNpmTasks('grunt-babel');
142-
grunt.loadNpmTasks('grunt-bg-shell');
140+
grunt.loadNpmTasks('grunt-shell');
143141
grunt.loadNpmTasks('grunt-webpack');
144142

145143
grunt.task.loadTasks('tasks');
@@ -156,7 +154,7 @@ module.exports = function(grunt) {
156154
// Requires secret properties from .travis.yaml
157155
grunt.registerTask('extensive-tests-and-publish-to-aws', [
158156
'default',
159-
'bgShell:integrationTests',
157+
'shell:integrationTests',
160158
'metrics',
161159
'publish-to-aws'
162160
]);
@@ -176,6 +174,6 @@ module.exports = function(grunt) {
176174
);
177175
grunt.registerTask('integration-tests', [
178176
'default',
179-
'bgShell:integrationTests'
177+
'shell:integrationTests'
180178
]);
181179
};

README.markdown

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ Supported Environments
8181

8282
Handlebars has been designed to work in any ECMAScript 3 environment. This includes
8383

84-
- Node.js 10+
84+
- Node.js 12+
8585
- Chrome
8686
- Firefox
8787
- Safari 5+

0 commit comments

Comments
 (0)