fix for wrong mousemove event on Chrome browser

[HobieCat]

On Chrome 34.0.1847.132 browser running on Kubuntu 13.04, Windows Vista/7 and OSX in jPlayer fullscreen mode, the gui does the fadeIn/fadeOut a random number of times even when the mouse is not moving. Fixed by checking if the the mouse has been actually moved before doing the fadeIn/fadeOut.

[lchenneberg]

This fix works well and resolved many issues... can you please merge this branch "asap" ?!

[thepag]

Hello @HobieCat would you please sign our CLA so that I can merge your contribution.

Sorry for the delay here, I was foolish and hoped Chrome would fix the bug they introduced, but I have now adopted the assumption that Chrome will not fix any of their browser bugs in a timely manner. I suppose once you have top browser share, you no longer have to care about little things like only generating a mouse move event if the mouse actually moved, rather than if some layer just disappeared that was under the mouse.

Another fail on my part was messing up the repo watching after I changed it to an organisation. I am now notified correctly of all issues and PRs.

[HobieCat]

Hi @thepag, I just signed your CLA.
Please feel free to merge at your convenience and let me know if I can be of any help solving possible conflicts.

Nevermind about the delay. BTW, looks like the bug is still there in v39.0.2171.65...

[thepag]

Cheers @HobieCat
I think it will be tomorrow now before I get round to doing this.

[thepag]

Going to merge this next. Think I'll change the check for undefined to better code:

typeof thing === 'undefined'

Since anyone can do undefined="banana"... But I suppose I do actually protect the undefined var in the jPlayer scope. But anyway, little tweaks like that and possibly removing your delete from the destroy code, since we do not need to explicitly delete every variable, or that destroy code would be huge.

[thepag]

Ignore what I said about the destroy code... I'd thought that delete line in the destroy, but it seems like you made deleting the variable part of your logic. I'll be reviewing that logic some more in due course.

I've made some changes to the indentation so it matches the rest of my (OCD) indentation.

I've changed some variable names, because they were verbose even by my standards 😄

I am using event.pageX and event.pageY since jQuery normalises those values... But probably makes no difference. Just noting these tweaks I'm making in case I break anything.

[HobieCat]

Yep, the delete line is part of the logic indeed. I'd rather be verbose than cryptic :)

[thepag]

I left the delete in. Yeah it's cool. I appreciated the readability. I just try and keep object property names shorter since they do not minify as easily. ie., without making a local copy in a function instead of using the huge pointer name each time. There are many parts of jPlayer that would benefit from that sort of local var scoping to improve the minification. But I often find myself wondering why I bother when the media files are so huge... Ah yes! - Page load time 😄