Skip to content

Commit 417d8c4

Browse files
shuijingliChun-Kuang Hu
authored andcommitted
drm/mediatek: dsi: Correct calculation formula of PHY Timing
This patch correct calculation formula of PHY timing. The spec define HS-PREPARE should be from 40ns+4*UI(44ns) to 85ns+6*UI(91ns). But current duration is 88ns and is near the boundary. So this patch make the duration to 64ns so it is near the safe range. Signed-off-by: Shuijing Li <[email protected]> Reviewed-by: CK Hu <[email protected]> Link: https://patchwork.kernel.org/project/dri-devel/patch/[email protected]/ Signed-off-by: Chun-Kuang Hu <[email protected]>
1 parent 8431fff commit 417d8c4

File tree

1 file changed

+16
-15
lines changed

1 file changed

+16
-15
lines changed

drivers/gpu/drm/mediatek/mtk_dsi.c

Lines changed: 16 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -242,22 +242,23 @@ static void mtk_dsi_phy_timconfig(struct mtk_dsi *dsi)
242242
u32 data_rate_mhz = DIV_ROUND_UP(dsi->data_rate, HZ_PER_MHZ);
243243
struct mtk_phy_timing *timing = &dsi->phy_timing;
244244

245-
timing->lpx = (60 * data_rate_mhz / (8 * 1000)) + 1;
246-
timing->da_hs_prepare = (80 * data_rate_mhz + 4 * 1000) / 8000;
247-
timing->da_hs_zero = (170 * data_rate_mhz + 10 * 1000) / 8000 + 1 -
245+
timing->lpx = (80 * data_rate_mhz / (8 * 1000)) + 1;
246+
timing->da_hs_prepare = (59 * data_rate_mhz + 4 * 1000) / 8000 + 1;
247+
timing->da_hs_zero = (163 * data_rate_mhz + 11 * 1000) / 8000 + 1 -
248248
timing->da_hs_prepare;
249-
timing->da_hs_trail = timing->da_hs_prepare + 1;
250-
251-
timing->ta_go = 4 * timing->lpx - 2;
252-
timing->ta_sure = timing->lpx + 2;
253-
timing->ta_get = 4 * timing->lpx;
254-
timing->da_hs_exit = 2 * timing->lpx + 1;
255-
256-
timing->clk_hs_prepare = 70 * data_rate_mhz / (8 * 1000);
257-
timing->clk_hs_post = timing->clk_hs_prepare + 8;
258-
timing->clk_hs_trail = timing->clk_hs_prepare;
259-
timing->clk_hs_zero = timing->clk_hs_trail * 4;
260-
timing->clk_hs_exit = 2 * timing->clk_hs_trail;
249+
timing->da_hs_trail = (78 * data_rate_mhz + 7 * 1000) / 8000 + 1;
250+
251+
timing->ta_go = 4 * timing->lpx;
252+
timing->ta_sure = 3 * timing->lpx / 2;
253+
timing->ta_get = 5 * timing->lpx;
254+
timing->da_hs_exit = (118 * data_rate_mhz / (8 * 1000)) + 1;
255+
256+
timing->clk_hs_prepare = (57 * data_rate_mhz / (8 * 1000)) + 1;
257+
timing->clk_hs_post = (65 * data_rate_mhz + 53 * 1000) / 8000 + 1;
258+
timing->clk_hs_trail = (78 * data_rate_mhz + 7 * 1000) / 8000 + 1;
259+
timing->clk_hs_zero = (330 * data_rate_mhz / (8 * 1000)) + 1 -
260+
timing->clk_hs_prepare;
261+
timing->clk_hs_exit = (118 * data_rate_mhz / (8 * 1000)) + 1;
261262

262263
timcon0 = FIELD_PREP(LPX, timing->lpx) |
263264
FIELD_PREP(HS_PREP, timing->da_hs_prepare) |

0 commit comments

Comments
 (0)