CronFieldCollection.from should allow passing in special chars (#387)

Author: harrisiirak

src/fields/CronField.ts

@@ -98,8 +98,8 @@ export abstract class CronField {
     };
     this.#values = values.sort(CronField.sorter);
     this.#wildcard = this.options.wildcard !== undefined ? this.options.wildcard : this.#isWildcardValue();
-    this.#hasLastChar = this.options.rawValue.includes('L');
-    this.#hasQuestionMarkChar = this.options.rawValue.includes('?');
+    this.#hasLastChar = this.options.rawValue.includes('L') || values.includes('L');
+    this.#hasQuestionMarkChar = this.options.rawValue.includes('?') || values.includes('?');
   }
 
   /**

src/fields/types.ts

@@ -9,7 +9,7 @@ export type SixtyRange = IntRange<RangeFrom<0>, 59>; // 0-59 - inclusive
 export type HourRange = IntRange<RangeFrom<0>, 23>; // 0-23 - inclusive
 export type DayOfMonthRange = IntRange<RangeFrom<1>, 31> | 'L'; // 1-31 - inclusive
 export type MonthRange = IntRange<RangeFrom<1>, 12>; // 1-12 - inclusive
-export type DayOfWeekRange = IntRange<RangeFrom<0>, 7>; // 0-7 - inclusive
+export type DayOfWeekRange = IntRange<RangeFrom<0>, 7> | 'L'; // 0-7 - inclusive
 export type CronFieldType = SixtyRange[] | HourRange[] | DayOfMonthRange[] | MonthRange[] | DayOfWeekRange[];
 export type CronChars = 'L' | 'W';
 export type CronMin = 0 | 1;

tests/CronFieldCollection.test.ts

@@ -333,6 +333,18 @@ describe('CronFieldCollection', () => {
       expect(result.minute.values).toEqual([30]);
     });
 
+    test('should handle special characters (L)', () => {
+      const result = CronFieldCollection.from(base, {
+        dayOfMonth: ['L'],
+        dayOfWeek: ['L'],
+      });
+      expect(result.dayOfMonth).not.toBe(base.dayOfMonth);
+      expect(result.dayOfMonth.values).toEqual(['L']);
+      expect(result.dayOfWeek).not.toBe(base.dayOfWeek);
+      expect(result.dayOfWeek.values).toEqual(['L']);
+      expect(result.stringify(true)).toEqual('0 0 12 L 1 L');
+    });
+
     test('should handle mix of CronField instances and raw values', () => {
       const newHour = new CronHour([15]);