Failure building images/gitea

[jnaulty]

Ran into issue when running make
Pinpointed issue to make images/gitea.tar

Seems like we need to upgrade the version of node + npm in the build container.

Here's a snippet of the error:

#5 [build 2/3] RUN git clone https://github.com/go-gitea/gitea.git ~/src   ...
#5 0.301 Cloning into '/home/build/src'...
#5 69.74 Note: checking out 'aa1d9ef6cba71c80170ec8c9ef424cb780fa6481'.
#5 69.74 
#5 69.74 You are in 'detached HEAD' state. You can look around, make experimental
#5 69.74 changes and commit them, and you can discard any commits you make in this
#5 69.74 state without impacting any branches by performing another checkout.
#5 69.74 
#5 69.74 If you want to create a new branch to retain commits you create, you may
#5 69.74 do so (now or later) by using -b with the checkout command again. Example:
#5 69.74 
#5 69.74   git checkout -b <new-branch-name>
#5 69.74 
#5 69.74 HEAD is now at aa1d9ef6c Changelog 1.12.5 (#13002)
#5 69.84 npm install --no-save
#5 70.33 npm WARN npm npm does not support Node.js v10.21.0
#5 70.34 npm WARN npm You should probably upgrade to a newer version of node as we
#5 70.34 npm WARN npm can't make any promises that npm will work with this version.
#5 70.34 npm WARN npm Supported releases of Node.js are the latest release of 4, 6, 7, 8, 9.
#5 70.34 npm WARN npm You can find the latest version at https://nodejs.org/

Here's a full paste of the error: http://paste.debian.net/1174757/

Side-Note:
It's interesting finding the security issues present in this version of gitea as well, that might need further upstream poking to fix though:

➜  stack git:(jnaulty/remove-old-stack-containers) ✗ cat make.build.log| grep -i security  
#5 75.62 npm WARN notice [SECURITY] yargs-parser has the following vulnerability: 1 low. Go here for more details: https://www.npmjs.com/advisories?search=yargs-parser&version=5.0.0 - Run `npm i npm@latest -g` to upgrade your npm version, and then `npm audit` to get more info.
#5 80.47 npm WARN notice [SECURITY] serialize-javascript has the following vulnerability: 1 high. Go here for more details: https://www.npmjs.com/advisories?search=serialize-javascript&version=2.1.2 - Run `npm i npm@latest -g` to upgrade your npm version, and then `npm audit` to get more info.
#5 83.40 npm WARN notice [SECURITY] url-regex has the following vulnerability: 1 high. Go here for more details: https://www.npmjs.com/advisories?search=url-regex&version=3.2.0 - Run `npm i npm@latest -g` to upgrade your npm version, and then `npm audit` to get more info.
#5 89.09 npm WARN notice [SECURITY] set-value has the following vulnerability: 1 high. Go here for more details: https://www.npmjs.com/advisories?search=set-value&version=2.0.1 - Run `npm i npm@latest -g` to upgrade your npm version, and then `npm audit` to get more info.
#5 89.59 npm WARN notice [SECURITY] serialize-javascript has the following vulnerability: 1 high. Go here for more details: https://www.npmjs.com/advisories?search=serialize-javascript&version=3.0.0 - Run `npm i npm@latest -g` to upgrade your npm version, and then `npm audit` to get more info.
#5 89.73 npm WARN notice [SECURITY] node-fetch has the following vulnerability: 1 low. Go here for more details: https://www.npmjs.com/advisories?search=node-fetch&version=1.7.3 - Run `npm i npm@latest -g` to upgrade your npm version, and then `npm audit` to get more info.
#5 93.54 npm WARN notice [SECURITY] node-fetch has the following vulnerability: 1 low. Go here for more details: https://www.npmjs.com/advisories?search=node-fetch&version=2.6.0 - Run `npm i npm@latest -g` to upgrade your npm version, and then `npm audit` to get more info.
#5 93.92 npm WARN notice [SECURITY] elliptic has the following vulnerability: 1 high. Go here for more details: https://www.npmjs.com/advisories?search=elliptic&version=6.5.2 - Run `npm i npm@latest -g` to upgrade your npm version, and then `npm audit` to get more info.
#5 94.50 npm WARN notice [SECURITY] lodash has the following vulnerabilities: 1 high, 1 low. Go here for more details: https://www.npmjs.com/advisories?search=lodash&version=4.17.15 - Run `npm i npm@latest -g` to upgrade your npm version, and then `npm audit` to get more info.

[jnaulty]

Going to see if make update-base resolves the issue.

[jnaulty]

updating npm might be the solution:
https://github.com/hashbang/stack/compare/master...jnaulty:jnaulty/update-npm-stack-base?expand=1

[jnaulty]

Tested updating the hash of gitea to the latest released version: v1.12.6 53b89c34742855e0c5a7f989d6506f02791678af.
Failed to build on the master branch, but works on the branch in #5

[jnaulty]

also, here's the npm error I'm getting, if that comes in handy later with the older version of npm

24867 http fetch GET 200 https://registry.npmjs.org/concat-with-sourcemaps/-/concat-with-sourcemaps-1.1.0.tgz 1035ms                                                                                                                  [0/8049]
24868 silly extract concat-with-sourcemaps@1.1.0 extracted to /home/build/src/node_modules/.staging/concat-with-sourcemaps-5cf7b679 (1041ms)
24869 http fetch GET 200 https://registry.npmjs.org/core-js/-/core-js-3.6.5.tgz 1077ms                                 
24870 silly extract caniuse-lite@1.0.30001058 extracted to /home/build/src/node_modules/.staging/caniuse-lite-ce2e246f (790ms)
24871 http fetch GET 200 https://registry.npmjs.org/atob/-/atob-2.1.2.tgz 693ms                                                                                                                                                               
24872 silly extract atob@2.1.2 extracted to /home/build/src/node_modules/.staging/atob-53f682ef (698ms)                
24873 http fetch GET 200 https://registry.npmjs.org/fork-stream/-/fork-stream-0.0.4.tgz 1886ms                         
24874 silly extract fork-stream@0.0.4 extracted to /home/build/src/node_modules/.staging/fork-stream-fc919197 (1904ms) 
24875 silly extract core-js@3.6.5 extracted to /home/build/src/node_modules/.staging/core-js-0d668c45 (1278ms)         
24876 silly extract core-js@2.6.11 extracted to /home/build/src/node_modules/.staging/core-js-839af4cb (850ms)                                                                                                                                
24877 http fetch GET 200 https://registry.npmjs.org/de-indent/-/de-indent-1.0.2.tgz 1470ms                             
24878 silly extract de-indent@1.0.2 extracted to /home/build/src/node_modules/.staging/de-indent-b9387558 (1475ms)     
24879 http fetch GET 200 https://registry.npmjs.org/monaco-editor/-/monaco-editor-0.20.0.tgz 12165ms                   
24880 silly extract monaco-editor@0.20.0 extracted to /home/build/src/node_modules/.staging/monaco-editor-ac270a98 (12187ms)
24881 http fetch GET 200 https://registry.npmjs.org/copy-descriptor/-/copy-descriptor-0.1.1.tgz 1632ms                 
24882 silly extract copy-descriptor@0.1.1 extracted to /home/build/src/node_modules/.staging/copy-descriptor-c40551dc (1643ms)
24883 http fetch GET 200 https://registry.npmjs.org/fomantic-ui/-/fomantic-ui-2.8.4.tgz 13024ms                        
24884 silly extract fomantic-ui@2.8.4 extracted to /home/build/src/node_modules/.staging/fomantic-ui-3a6c37e5 (13031ms)        
24885 error cb() never called!      
24886 error This is an error with npm itself. Please report this error at:                                                                                                                                                                    
24887 error <https://github.com/npm/npm/issues>