From ed0419214ce3c8328138defc771dec199f3dd401 Mon Sep 17 00:00:00 2001 From: Venus Ang Date: Tue, 26 Aug 2025 16:50:53 -0700 Subject: [PATCH 1/4] =?UTF-8?q?refactor:=20=F0=9F=92=A1=20add=20edit-user-?= =?UTF-8?q?details=20translations?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This adds edit user details translations so the User detail form submit button is a11y compliant ✅ Closes: FE-112 --- addons/core/translations/actions/en-us.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/addons/core/translations/actions/en-us.yaml b/addons/core/translations/actions/en-us.yaml index 7ed7bcd097..d5fa502545 100644 --- a/addons/core/translations/actions/en-us.yaml +++ b/addons/core/translations/actions/en-us.yaml @@ -38,6 +38,9 @@ add-hosts: Add Hosts set-password: Set Password change-password: Change Password edit-form: Edit Form +edit-user-details: + button-text: Edit User details + aria-label: 'edit form: users' change-cluster-url: Change Cluster URL change-state: Change State close: Close From f7082ea8e5393fe1254c62443a3eeac5677acea5 Mon Sep 17 00:00:00 2001 From: Venus Ang Date: Tue, 26 Aug 2025 16:53:50 -0700 Subject: [PATCH 2/4] =?UTF-8?q?refactor:=20=F0=9F=92=A1=20change=20inputs?= =?UTF-8?q?=20to=20readonly=20and=20update=20submit=20button?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Per a11y audit, this changes the input fields to readonly instead of disabled. It also updates the submit button text so that it is context based and has an aria-label for screenreaders. ✅ Closes: FE-112 --- ui/admin/app/components/form/user/index.hbs | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/ui/admin/app/components/form/user/index.hbs b/ui/admin/app/components/form/user/index.hbs index e6ec03f927..622a0b0cc9 100644 --- a/ui/admin/app/components/form/user/index.hbs +++ b/ui/admin/app/components/form/user/index.hbs @@ -16,7 +16,7 @@ @value={{@model.name}} @isInvalid={{@model.errors.name}} @isOptional={{true}} - disabled={{form.disabled}} + readonly={{form.disabled}} {{on 'input' (set-from-event @model 'name')}} as |F| > @@ -36,7 +36,7 @@ @value={{@model.description}} @isInvalid={{@model.errors.description}} @isOptional={{true}} - disabled={{form.disabled}} + readonly={{form.disabled}} as |F| > {{t 'form.description.label'}} @@ -52,7 +52,8 @@ {{#if (can 'save model' @model)}} From 334e7d6eed3b380b6b7a19b783e2253141bd0a8d Mon Sep 17 00:00:00 2001 From: Venus Ang Date: Wed, 27 Aug 2025 10:54:53 -0700 Subject: [PATCH 3/4] =?UTF-8?q?refactor:=20=F0=9F=92=A1=20move=20translati?= =?UTF-8?q?on=20to=20resources=20for=20user?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This moves the User detail action translation to resources/en-us.yaml since it is specific to the user resource and is not a generic form action. ✅ Closes: FE-112 --- addons/core/translations/actions/en-us.yaml | 3 --- addons/core/translations/resources/en-us.yaml | 4 ++++ ui/admin/app/components/form/user/index.hbs | 4 ++-- 3 files changed, 6 insertions(+), 5 deletions(-) diff --git a/addons/core/translations/actions/en-us.yaml b/addons/core/translations/actions/en-us.yaml index d5fa502545..7ed7bcd097 100644 --- a/addons/core/translations/actions/en-us.yaml +++ b/addons/core/translations/actions/en-us.yaml @@ -38,9 +38,6 @@ add-hosts: Add Hosts set-password: Set Password change-password: Change Password edit-form: Edit Form -edit-user-details: - button-text: Edit User details - aria-label: 'edit form: users' change-cluster-url: Change Cluster URL change-state: Change State close: Close diff --git a/addons/core/translations/resources/en-us.yaml b/addons/core/translations/resources/en-us.yaml index 554d81b9c7..d2e80983de 100644 --- a/addons/core/translations/resources/en-us.yaml +++ b/addons/core/translations/resources/en-us.yaml @@ -570,6 +570,10 @@ user: actions: add-accounts: Add Accounts delete: Delete User + edit-details: + button: + text: Edit User details + aria-label: 'edit form: users' role: title: Role title_plural: Roles diff --git a/ui/admin/app/components/form/user/index.hbs b/ui/admin/app/components/form/user/index.hbs index 622a0b0cc9..b4978b130b 100644 --- a/ui/admin/app/components/form/user/index.hbs +++ b/ui/admin/app/components/form/user/index.hbs @@ -52,8 +52,8 @@ {{#if (can 'save model' @model)}} From d86805c77fa9a3f27df715395ba08f6d44cb75bc Mon Sep 17 00:00:00 2001 From: Venus Ang Date: Fri, 29 Aug 2025 08:22:11 -0700 Subject: [PATCH 4/4] =?UTF-8?q?refactor:=20=F0=9F=92=A1=20removed=20aria-l?= =?UTF-8?q?abel=20from=20button=20set?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This was not sending the aria-label down to the Edit Users detail button. However, taking a look further at Hds::Button, this component does not allow aria-label to be set unless it is an icon only button. With that said, this cleans up the translation structure and removes the aria-label translation and mark-up. ✅ Closes: FE-112 --- addons/core/translations/resources/en-us.yaml | 5 +---- ui/admin/app/components/form/user/index.hbs | 3 +-- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/addons/core/translations/resources/en-us.yaml b/addons/core/translations/resources/en-us.yaml index d2e80983de..5d675b57c3 100644 --- a/addons/core/translations/resources/en-us.yaml +++ b/addons/core/translations/resources/en-us.yaml @@ -570,10 +570,7 @@ user: actions: add-accounts: Add Accounts delete: Delete User - edit-details: - button: - text: Edit User details - aria-label: 'edit form: users' + edit-details: 'Edit User details' role: title: Role title_plural: Roles diff --git a/ui/admin/app/components/form/user/index.hbs b/ui/admin/app/components/form/user/index.hbs index b4978b130b..b71d0fdac7 100644 --- a/ui/admin/app/components/form/user/index.hbs +++ b/ui/admin/app/components/form/user/index.hbs @@ -52,8 +52,7 @@ {{#if (can 'save model' @model)}}