Skip to content

Commit 48b57c3

Browse files
authored
fix(components): add missing template registries (#2954)
1 parent 627286a commit 48b57c3

File tree

8 files changed

+30
-16
lines changed

8 files changed

+30
-16
lines changed

.changeset/sour-needles-own.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@hashicorp/design-system-components': patch
3+
---
4+
5+
Upgraded: `@nullvoxpopuli/ember-composable-helpers` from 5.2.10 to 5.2.11

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
},
2727
"pnpm": {
2828
"overrides": {
29-
"ember-composable-helpers": "npm:@nullvoxpopuli/ember-composable-helpers@^5.2.10"
29+
"ember-composable-helpers": "npm:@nullvoxpopuli/ember-composable-helpers@^5.2.11"
3030
},
3131
"patchedDependencies": {
3232
"@embroider/core": "patches/@embroider__core.patch",

packages/components/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@
5555
"@hashicorp/design-system-tokens": "workspace:^2.3.0",
5656
"@hashicorp/flight-icons": "workspace:^3.11.1",
5757
"@lezer/highlight": "^1.2.1",
58-
"@nullvoxpopuli/ember-composable-helpers": "^5.2.10",
58+
"@nullvoxpopuli/ember-composable-helpers": "^5.2.11",
5959
"clipboard-polyfill": "^4.1.1",
6060
"codemirror-lang-hcl": "^0.0.0-beta.2",
6161
"decorator-transforms": "^2.3.0",

packages/components/src/components/hds/advanced-table/index.hbs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,7 @@
7878
we yield the Tr/Td/Th elements _and_ the record itself as `data`
7979
this means the consumer will *have to* use the `data` key to access it in their template
8080
-------------------------------------------------------------------------------------------- }}
81+
{{! @glint-expect-error: [HDS-4380](https://hashicorp.atlassian.net/browse/HDS-4380) }}
8182
{{#each (sort-by this.getSortCriteria this._tableModel.rows) key=this.identityKey as |record index|}}
8283
{{#if this._tableModel.hasRowsWithChildren}}
8384
<Hds::AdvancedTable::ExpandableTrGroup

packages/components/src/components/hds/table/index.hbs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,7 @@
7575
we yield the Tr/Td/Th elements _and_ the record itself as `data`
7676
this means the consumer will *have to* use the `data` key to access it in their template
7777
-------------------------------------------------------------------------------------------- }}
78+
{{! @glint-expect-error: [HDS-4380](https://hashicorp.atlassian.net/browse/HDS-4380) }}
7879
{{#each (sort-by this.getSortCriteria @model) key=this.identityKey as |record index|}}
7980
{{yield
8081
(hash

packages/components/unpublished-development-types/global.d.ts

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ import type PowerSelectRegistry from 'ember-power-select/template-registry';
1212
import type { EmbroiderUtilRegistry } from '@embroider/util';
1313
// eslint-disable-next-line ember/no-at-ember-render-modifiers
1414
import type RenderModifiersRegistry from '@ember/render-modifiers/template-registry';
15+
import type EmberComposableHelpersRegistry from '@nullvoxpopuli/ember-composable-helpers/template-registry';
1516

1617
declare module '@glint/environment-ember-loose/registry' {
1718
export default interface Registry
@@ -22,15 +23,10 @@ declare module '@glint/environment-ember-loose/registry' {
2223
EmberTruthRegistry,
2324
PowerSelectRegistry,
2425
RenderModifiersRegistry,
26+
EmberComposableHelpersRegistry,
2527
EmbroiderUtilRegistry /*, other addon registries */ {
2628
// local entries
2729
Portal: typeof Portal;
2830
PortalTarget: typeof PortalTarget;
29-
'sort-by': HelperLike<{
30-
Args: {
31-
Positional: [string[], unknown[]];
32-
};
33-
Return: unknown[];
34-
}>;
3531
}
3632
}

pnpm-lock.yaml

Lines changed: 7 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

showcase/types/global.d.ts

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,8 @@ import type PageTitle from 'ember-page-title/template-registry';
1313
// eslint-disable-next-line ember/no-at-ember-render-modifiers
1414
import type RenderModifiersRegistry from '@ember/render-modifiers/template-registry';
1515
import type ShowcaseTemplateRegistry from './template-registry';
16+
import type EmberComposableHelpersRegistry from '@nullvoxpopuli/ember-composable-helpers/template-registry';
17+
import type { HelperLike } from '@glint/template';
1618

1719
declare module '@glint/environment-ember-loose/registry' {
1820
export default interface Registry
@@ -21,5 +23,14 @@ declare module '@glint/environment-ember-loose/registry' {
2123
HdsComponentsRegistry,
2224
PageTitle,
2325
RenderModifiersRegistry,
24-
ShowcaseTemplateRegistry {}
26+
ShowcaseTemplateRegistry,
27+
EmberComposableHelpersRegistry {
28+
// TODO: `ember-cli-string-helpers` is deprecated and doesn't provide own types, we need to move to `@ember/string` [HDS-4973](https://hashicorp.atlassian.net/browse/HDS-4973)
29+
capitalize: HelperLike<{
30+
Args: {
31+
Positional: [string];
32+
};
33+
Return: string;
34+
}>;
35+
}
2536
}

0 commit comments

Comments
 (0)