Remove ember-flight-icons (#2881)

Co-authored-by: shleewhite <[email protected]>

Author: shleewhite

.changeset/config.json

@@ -12,7 +12,7 @@
   "___experimentalUnsafeOptions_WILL_CHANGE_IN_PATCH": {
     "updateInternalDependents": "always"
   },
-  "ignore": ["@hashicorp/ember-flight-icons", "showcase", "website"],
+  "ignore": ["showcase", "website"],
   "snapshot": {
     "useCalculatedVersion": true
   }

.github/labeler.yml

@@ -6,10 +6,6 @@ packages/components:
   - changed-files:
     - any-glob-to-any-file:
       - packages/components/**/*
-packages/ember-flight-icons:
-  - changed-files:
-    - any-glob-to-any-file:
-      - packages/ember-flight-icons/**/*
 packages/flight-icons:
   - changed-files:
     - any-glob-to-any-file:

README.md

@@ -24,14 +24,6 @@ Design System components in Ember.js
 - website: [https://helios.hashicorp.design/components](https://helios.hashicorp.design/components)
 - more info: see [components/README](packages/components/README.md) and [components/CONTRIBUTING](packages/components/CONTRIBUTING.md).
 
-### `packages/ember-flight-icons` [![npm version](https://badge.fury.io/js/%40hashicorp%2Fember-flight-icons.svg)](https://badge.fury.io/js/%40hashicorp%2Fember-flight-icons)
-
-Ember.js addon with `<FlightIcon />` component (deprecated)
-
-- npm package: `@hashicorp/ember-flight-icons`
-- website: [https://helios.hashicorp.design/icons/library](https://helios.hashicorp.design/icons/library)
-- more info: see [ember-flight-icons/README](packages/ember-flight-icons/README.md) and [ember-flight-icons/CONTRIBUTING](packages/ember-flight-icons/CONTRIBUTING.md) for details on how to build and test the Ember.js addon.
-
 ### `packages/flight-icons` [![npm version](https://badge.fury.io/js/%40hashicorp%2Fflight-icons.svg)](https://badge.fury.io/js/%40hashicorp%2Fflight-icons)
 
 - website: [https://helios.hashicorp.design/icons/library](https://helios.hashicorp.design/icons/library)

packages/components/addon-main.cjs

@@ -9,8 +9,11 @@ const flightIconSprite = require('@hashicorp/flight-icons/svg-sprite/svg-sprite-
 module.exports = {
   ...addonV1Shim(__dirname),
   contentFor(type, config) {
+    const legacyLazyEmbed = config?.emberFlightIcons?.lazyEmbed;
+
     if (
-      !config.emberFlightIcons?.lazyEmbed &&
+      !config.flightIconsSpriteLazyEmbed &&
+      !legacyLazyEmbed &&
       !config.__flightIconsSpriteLoaded &&
       type === 'body-footer'
     ) {

packages/components/src/instance-initializers/load-sprite.ts

@@ -6,8 +6,11 @@
 import config from 'ember-get-config';
 
 export async function initialize() {
+  // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-unsafe-assignment
+  const legacyLazyEmbed = config?.emberFlightIcons?.lazyEmbed;
+
   // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
-  if (config?.emberFlightIcons?.lazyEmbed) {
+  if (config?.flightIconsSpriteLazyEmbed || legacyLazyEmbed) {
     const { default: svgSprite } = await import(
       '@hashicorp/flight-icons/svg-sprite/svg-sprite-module'
     );