Merge pull request #161 from hashicorp/jbardin/stopping-recv-loop

jbardin · web-flow · commit 0c19a1387af1 · 2020-11-06T15:51:48.000-05:00
grpc stream errors are terminal
diff --git a/grpc_stdio.go b/grpc_stdio.go
@@ -136,12 +136,12 @@ func (c *grpcStdioClient) Run(stdout, stderr io.Writer) {
 				status.Code(err) == codes.Canceled ||
 				status.Code(err) == codes.Unimplemented ||
 				err == context.Canceled {
-				c.log.Warn("received EOF, stopping recv loop", "err", err)
+				c.log.Debug("received EOF, stopping recv loop", "err", err)
 				return
 			}
 
 			c.log.Error("error receiving data", "err", err)
-			continue
+			return
 		}
 
 		// Determine our output writer based on channel

Original file line number	Diff line number	Diff line change
`@@ -136,12 +136,12 @@ func (c *grpcStdioClient) Run(stdout, stderr io.Writer) {`
`136`	`136`	`status.Code(err) == codes.Canceled \|\|`
`137`	`137`	`status.Code(err) == codes.Unimplemented \|\|`
`138`	`138`	`err == context.Canceled {`
`139`		`- c.log.Warn("received EOF, stopping recv loop", "err", err)`
	`139`	`+ c.log.Debug("received EOF, stopping recv loop", "err", err)`
`140`	`140`	`return`
`141`	`141`	`}`
`142`	`142`
`143`	`143`	`c.log.Error("error receiving data", "err", err)`
`144`		`- continue`
	`144`	`+ return`
`145`	`145`	`}`
`146`	`146`
`147`	`147`	`// Determine our output writer based on channel`