chore(structs): add TestDiff_SidecarIdentities

Author: 3nprob

nomad/structs/diff_test.go

@@ -10437,6 +10437,235 @@ func TestServicesDiff(t *testing.T) {
 	}
 }
 
+func TestDiff_SidecarIdentities(t *testing.T) {
+	oldTask := &SidecarTask{
+		Name:   "old",
+		Driver: "docker",
+		User:   "sidecar",
+		Config: map[string]any{"foo": "bar"},
+		Env:    map[string]string{"FOO": "BAR"},
+		Resources: &Resources{
+			Cores: 2,
+			NUMA: &NUMA{
+				Affinity: "none",
+			},
+		},
+		Meta:        map[string]string{"meta": "val"},
+		KillTimeout: pointer.Of(10 * time.Second),
+		LogConfig: &LogConfig{
+			MaxFiles:      3,
+			MaxFileSizeMB: 100,
+		},
+		ShutdownDelay: pointer.Of(20 * time.Second),
+		KillSignal:    "SIGUSR1",
+		Identities: []*WorkloadIdentity{
+			{
+				Name:         "fooident",
+				Audience:     []string{"foo.bar"},
+				ChangeMode:   "signal",
+				ChangeSignal: "SIGHUP2",
+			},
+		},
+	}
+	newTask := &SidecarTask{
+		Name:   "new",
+		Driver: "podman",
+		User:   "proxy",
+		Config: map[string]any{"eggs": "spam"},
+		Env:    map[string]string{"EGGS": "SPAM"},
+		Resources: &Resources{
+			Cores: 4,
+			NUMA: &NUMA{
+				Affinity: "prefer",
+			},
+		},
+		Meta:        map[string]string{"meta": "val"},
+		KillTimeout: pointer.Of(10 * time.Second),
+		LogConfig: &LogConfig{
+			MaxFiles:      3,
+			MaxFileSizeMB: 100,
+		},
+		ShutdownDelay: pointer.Of(20 * time.Second),
+		KillSignal:    "SIGUSR1",
+		Identities: []*WorkloadIdentity{
+			{
+				Name:         "fooident",
+				Audience:     []string{"foo.bar", "new.foo.bar"},
+				ChangeMode:   "signal",
+				ChangeSignal: "SIGHUP3",
+			},
+			{
+				Name:         "barident",
+				Audience:     []string{"bar.foo"},
+				ChangeMode:   "signal",
+				ChangeSignal: "SIGHUP",
+			},
+		},
+	}
+	expected := &ObjectDiff{
+		Type: DiffTypeEdited,
+		Name: "SidecarTask",
+		Fields: []*FieldDiff{
+			{
+				Type: DiffTypeEdited,
+				Name: "Driver",
+				Old:  "docker",
+				New:  "podman",
+			},
+			{
+				Type: DiffTypeAdded,
+				Name: "Env[EGGS]",
+				Old:  "",
+				New:  "SPAM",
+			},
+			{
+				Type: DiffTypeDeleted,
+				Name: "Env[FOO]",
+				Old:  "BAR",
+				New:  "",
+			},
+			{
+				Type: DiffTypeEdited,
+				Name: "Name",
+				Old:  "old",
+				New:  "new",
+			},
+			{
+				Type: DiffTypeEdited,
+				Name: "User",
+				Old:  "sidecar",
+				New:  "proxy",
+			},
+		},
+		Objects: []*ObjectDiff{
+			{
+				Type: DiffTypeEdited,
+				Name: "Config",
+				Fields: []*FieldDiff{
+					{
+						Type: DiffTypeAdded,
+						Name: "eggs",
+						Old:  "",
+						New:  "spam",
+					},
+					{
+						Type: DiffTypeDeleted,
+						Name: "foo",
+						Old:  "bar",
+						New:  "",
+					},
+				},
+			},
+			{
+				Type: DiffTypeEdited,
+				Name: "Resources",
+				Fields: []*FieldDiff{
+					{
+						Type: DiffTypeNone,
+						Name: "CPU",
+						Old:  "0",
+						New:  "0",
+					},
+					{
+						Type: DiffTypeEdited,
+						Name: "Cores",
+						Old:  "2",
+						New:  "4",
+					},
+					{
+						Type: DiffTypeNone,
+						Name: "DiskMB",
+						Old:  "0",
+						New:  "0",
+					},
+					{
+						Type: DiffTypeNone,
+						Name: "IOPS",
+						Old:  "0",
+						New:  "0",
+					},
+					{
+						Type: DiffTypeNone,
+						Name: "MemoryMB",
+						Old:  "0",
+						New:  "0",
+					},
+					{
+						Type: DiffTypeNone,
+						Name: "MemoryMaxMB",
+						Old:  "0",
+						New:  "0",
+					},
+					{
+						Type: DiffTypeNone,
+						Name: "SecretsMB",
+						Old:  "0",
+						New:  "0",
+					},
+				},
+				Objects: []*ObjectDiff{
+					{
+						Type: DiffTypeEdited,
+						Name: "NUMA",
+						Fields: []*FieldDiff{
+							{
+								Type: DiffTypeEdited,
+								Name: "Affinity",
+								Old:  "none",
+								New:  "prefer",
+							},
+						},
+					},
+				},
+			},
+			{
+				Type: DiffTypeEdited,
+				Name: "Identity",
+				Fields: []*FieldDiff{
+					{Type: "None", Name: "ChangeMode", Old: "signal", New: "signal"},
+					{Type: "Edited", Name: "ChangeSignal", Old: "SIGHUP2", New: "SIGHUP3"},
+					{Type: "None", Name: "Env", Old: "false", New: "false"},
+					{Type: "None", Name: "File", Old: "false", New: "false"},
+					{Type: "None", Name: "Filepath"},
+					{Type: "None", Name: "Name", Old: "fooident", New: "fooident"},
+					{Type: "None", Name: "ServiceName"},
+					{Type: "None", Name: "TTL", Old: "0", New: "0"},
+				},
+				Objects: []*ObjectDiff{
+					{Type: "Added", Name: "Audience", Fields: []*FieldDiff{
+						{Type: "Added", Name: "Audience", New: "new.foo.bar"},
+						{Type: "None", Name: "Audience", Old: "foo.bar", New: "foo.bar"},
+					},
+					},
+				},
+			},
+			{
+				Type: DiffTypeAdded,
+				Name: "Identity",
+				Fields: []*FieldDiff{
+					{Type: "Added", Name: "ChangeMode", New: "signal"},
+					{Type: "Added", Name: "ChangeSignal", New: "SIGHUP"},
+					{Type: "Added", Name: "Env", New: "false"},
+					{Type: "Added", Name: "File", New: "false"},
+					{Type: "None", Name: "Filepath"},
+					{Type: "Added", Name: "Name", New: "barident"},
+					{Type: "None", Name: "ServiceName"},
+					{Type: "Added", Name: "TTL", New: "0"},
+				},
+				Objects: []*ObjectDiff{
+					{Type: "Added", Name: "Audience", Fields: []*FieldDiff{
+						{Type: "Added", Name: "Audience", New: "bar.foo"},
+					},
+					},
+				},
+			},
+		},
+	}
+
+	actual := sidecarTaskDiff(oldTask, newTask, true)
+	must.Eq(t, expected, actual)
+}
+
 // TestDiff_SidecarVolumes asserts changes to sidecar task volumes are
 // detected. See #25878
 func TestDiff_SidecarVolumes(t *testing.T) {