Conversation
e167655 to
ac4dc94
Compare
| if len(possible) > 0 { | ||
| out, err := csiFormatVolumes(possible, false, "") |
There was a problem hiding this comment.
I'm not seeing test coverage for this, and if it were handled incorrectly (a bug introduced later?), it could cause external persistent state to be lost.
There was a problem hiding this comment.
We don't have any CLI unit coverage for the volume delete command and very little meaningful coverage of the CSI HTTP APIs at all for that matter, because of the setup requirements. We pretty much just test the routing and that's about it; the functionality is being covered in the RPC handler tests. The juice isn't worth the squeeze for coverage here.
fc56656 to
b669a7a
Compare
The `volume delete` command doesn't allow using a prefix for the volume ID for either CSI or dynamic host volumes. Use a prefix search and wildcard namespace as we do for other CLI commands. Ref: https://hashicorp.atlassian.net/browse/NET-12057
b669a7a to
94e6821
Compare
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
The
volume deletecommand doesn't allow using a prefix for the volume ID for either CSI or dynamic host volumes. Use a prefix search and wildcard namespace as we do for other CLI commands.Ref: https://hashicorp.atlassian.net/browse/NET-12057
Example of use: