Allow for in-place update when affinity or spread was changed#25109
Conversation
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
d610da8 to
61f8aad
Compare
tgross
left a comment
There was a problem hiding this comment.
This looks great @pawelbeza! Thanks!
We've had a discussion internally and have some concerns that folks may be relying on the buggy behavior, even though it wasn't documented either way (Hyrum's Law). So we're going to merge this but hold off on releasing it until the next major version of Nomad (1.10.0 LTS).
I've rebased this PR on main and pushed a commit with some documentation updates. I'll need to pull in another reviewer to merge.
aimeeu
left a comment
There was a problem hiding this comment.
Thanks Tim for adding the docs!
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Fixes #25070
Similarly to #6732 it removes checking affinity and spread for inplace update.
Both affinity and spread should be as soft preference for Nomad scheduler rather than strict constraint. Therefore modifying them should not trigger job reallocation.