Add docker plugin config option image_pull_timeout value for default timeout#25489
Add docker plugin config option image_pull_timeout value for default timeout#25489allisonlarson merged 3 commits intomainfrom
Conversation
5eba255 to
8d379ac
Compare
8d379ac to
6a440a0
Compare
aimeeu
left a comment
There was a problem hiding this comment.
Thanks for updating the docs! I left a nit style guide suggestion. Nomad content has a lot of future tense, but I'm slowly changing that to present tense. I put the most important style guidance into our team-nomad docs.md file so you don't have to wade through the existing Education and Eng style guides.
tgross
left a comment
There was a problem hiding this comment.
LGTM!
Because this is a user-facing change we want a changelog entry. There's a makefile target make cl which runs a little "wizard" in the shell to generate a changelog snippet; all the snippets for a given version get combined with automation during the release process.
6a440a0 to
8c2bce8
Compare
8c2bce8 to
e164d26
Compare
There was a problem hiding this comment.
LGTM!
I've removed the backport/website label because we don't want docs changes for unreleased new features to ship immediately. Edit: and the backport/1.9.x label as the next scheduled release is the 1.10 GA so this, as a new feature, will ship in 1.10 but not 1.9.x
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Description
Adds a docker plugin config option for setting a default
image_pull_timeoutfor all tasks. This can be overridden by the task config option, if a different timeout is desired. The default timeout remains at 5m.Also adds the value to the docs.
Testing & Reproduction steps
Links
Fixes #25057
Contributor Checklist
changelog entry using the
make clcommand.ensure regressions will be caught.
and job configuration, please update the Nomad website documentation to reflect this. Refer to
the website README for docs guidelines. Please also consider whether the
change requires notes within the upgrade guide.
Reviewer Checklist
backporting document.
in the majority of situations. The main exceptions are long-lived feature branches or merges where
history should be preserved.
within the public repository.